Skip to content

Commit

Permalink
Corrected Secret Name and Namespace Params (#849)
Browse files Browse the repository at this point in the history
* Corrected Param Names

* Bump Image
  • Loading branch information
ralikio authored Aug 26, 2024
1 parent 31125e5 commit e275dc7
Show file tree
Hide file tree
Showing 8 changed files with 24 additions and 24 deletions.
4 changes: 2 additions & 2 deletions docs/contributor/09-10-ui.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ Follow the steps below to run BTP Manager with UI:
```
3. Set the **IMG** environment variable to the image of BTP Manager with UI.
```shell
export IMG=europe-docker.pkg.dev/kyma-project/dev/btp-manager:PR-845
export IMG=europe-docker.pkg.dev/kyma-project/dev/btp-manager:PR-849
```
4. Run `deploy` makefile rule to deploy BTP Manager with UI.
```shell
Expand All @@ -42,7 +42,7 @@ Follow the steps below to run BTP Manager with UI:
```
If you encounter the following error during Pod creation due to Warden's admission webhook:
```
Error creating: admission webhook "validation.webhook.warden.kyma-project.io" denied the request: Pod images europe-docker.pkg.dev/kyma-project/dev/btp-manager:PR-845 validation failed
Error creating: admission webhook "validation.webhook.warden.kyma-project.io" denied the request: Pod images europe-docker.pkg.dev/kyma-project/dev/btp-manager:PR-849 validation failed
```
you must scale the BTP Manager deployment to 0 replicas, delete the webhook, and then scale the deployment back to 1 replica.
```shell
Expand Down
8 changes: 4 additions & 4 deletions ui/src/components/CreateBindingForm.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -33,13 +33,13 @@ function CreateBindingForm(props: any) {
.post<ServiceInstanceBinding>(api("service-bindings"), {
name: createdBinding.name,
service_instance_id: createdBinding.service_instance_id,
secret_name: createdBinding.secret_name,
secret_namespace: createdBinding.secret_namespace
sm_secret_name: createdBinding.secret_name,
sm_secret_namespace: createdBinding.secret_namespace
}, {
params:
{
secret_name: props.secret!!.name,
secret_namespace: props.secret!!.namespace
sm_secret_name: props.secret!!.name,
sm_secret_namespace: props.secret!!.namespace
}
})
.then((response) => {
Expand Down
4 changes: 2 additions & 2 deletions ui/src/components/CreateInstanceForm.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,8 @@ function CreateInstanceForm(props: any) {
.post<CreateServiceInstance>(api("service-instances"), createdJson, {
params:
{
secret_name: props.secret!!.name,
secret_namespace: props.secret!!.namespace
sm_secret_name: props.secret!!.name,
sm_secret_namespace: props.secret!!.namespace
}
})
.then((response) => {
Expand Down
4 changes: 2 additions & 2 deletions ui/src/components/SecretsView.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@ function SecretsView({ onSecretChanged }: { onSecretChanged: (secret: string) =>
.get<ServiceOfferings>(api(`service-offerings/${response.data.items[0].namespace}/${response.data.items[0].name}`), {
params:
{
secret_name: response.data.items[0].name,
secret_namespace: response.data.items[0].namespace
sm_secret_name: response.data.items[0].name,
sm_secret_namespace: response.data.items[0].namespace
}
})
.then(() => {
Expand Down
8 changes: 4 additions & 4 deletions ui/src/components/ServiceBindingsList.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,8 @@ const ServiceBindingsList = forwardRef((props: any, ref) => {
axios
.delete(api("service-bindings") + "/" + id, {
params: {
secret_name: props.secret.name,
secret_namespace: props.secret.namespace
sm_secret_name: props.secret.name,
sm_secret_namespace: props.secret.namespace
}
})
.then((response) => {
Expand Down Expand Up @@ -77,8 +77,8 @@ const ServiceBindingsList = forwardRef((props: any, ref) => {
params:
{
service_instance_id: props.instance.id,
secret_name: props.secret.name,
secret_namespace: props.secret.namespace
sm_secret_name: props.secret.name,
sm_secret_namespace: props.secret.namespace
}
}
)
Expand Down
12 changes: 6 additions & 6 deletions ui/src/components/ServiceInstancesView.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,8 @@ function ServiceInstancesView(props: any) {
.get<ServiceOfferings>(
api(`service-offerings/${secret.namespace}/${secret.name}`), {
params: {
secret_name: secret.name,
secret_namespace: secret.namespace
sm_secret_name: secret.name,
sm_secret_namespace: secret.namespace
}
}
)
Expand All @@ -58,8 +58,8 @@ function ServiceInstancesView(props: any) {
axios
.get<ServiceInstances>(api("service-instances"), {
params: {
secret_name: secret.name,
secret_namespace: secret.namespace
sm_secret_name: secret.name,
sm_secret_namespace: secret.namespace
}
})
.then((response) => {
Expand Down Expand Up @@ -110,8 +110,8 @@ function ServiceInstancesView(props: any) {
axios
.delete(api("service-instances") + "/" + id, {
params: {
secret_name: secret.name,
secret_namespace: secret.namespace
sm_secret_name: secret.name,
sm_secret_namespace: secret.namespace
}
})
.then((response) => {
Expand Down
4 changes: 2 additions & 2 deletions ui/src/components/ServiceOfferingsDetailsView.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,8 @@ function ServiceOfferingsDetailsView(props: any) {
{
params:
{
secret_name: secret!!.name,
secret_namespace: secret!!.namespace
sm_secret_name: secret!!.name,
sm_secret_namespace: secret!!.namespace
}
})
.then((response) => {
Expand Down
4 changes: 2 additions & 2 deletions ui/src/components/ServiceOfferingsView.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,8 @@ function ServiceOfferingsView(props: any) {
), {
params:
{
secret_name: secret.name,
secret_namespace: secret.namespace
sm_secret_name: secret.name,
sm_secret_namespace: secret.namespace
}
}
)
Expand Down

0 comments on commit e275dc7

Please sign in to comment.