Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix naming in security-config-file of Application-Connector-Manager #256

Open
tobiscr opened this issue Apr 24, 2024 · 0 comments
Open

Fix naming in security-config-file of Application-Connector-Manager #256

tobiscr opened this issue Apr 24, 2024 · 0 comments
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@tobiscr
Copy link
Contributor

tobiscr commented Apr 24, 2024

Description

Wie agreed with our release manager to call ACM module in the security configuration Application Connector (at the moment it's `Application Connector Manager' ).

The name was in the past already changed to Application Connector which was responsible that an additonal project was created in MEND and Checkmarx with the name. Application Connector. At the moment, we have two projects in our security scanners in place (one for Application Connector Manager and another one for Application Connector).

We agreed to use in all SAP tools the name of the Kyma module which is Application Connector . Therefore, we should

  1. Update the security-config-file.yaml to use now the name Application Connector as module name (ensure there are no workflows in GH which are updating this file and avoid that it's renamed again back to Application Connector Manager.

  2. Get in touch with Neighbors to get rid of the no longer used Application Connector MAnager...-projects in our security scanner tools (w.g. for CX or MEND: kyma_application-connector-manager_main) - final goal is to have only one checkbox in the Kyma security dashboard shown:

    Screenshot 2024-04-24 at 10 58 16

Expected result

Consistent naming used for Application Connector module in all SAP security scanners

Actual result

We use the name Application Connector Manager in the SAP securtity scanners instead of Application Connector.

Steps to reproduce

Check created projects in security scanner and see offereed checkboxed in Kyma security dashboard.

Troubleshooting

@tobiscr tobiscr added the kind/bug Categorizes issue or PR as related to a bug. label Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

No branches or pull requests

1 participant