Support only PHP 8.3 #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Only support PHP 8.3
- Make classes read-only when possible
- Add types to constants
- Upgrade PHPUnit to v11.3
- Use static versions of asserts and expectations of invocations
- Change CI pipeline to use PHP 8.3
- Bump to use `kununu/data-fixtures` 12.0
- Changes on `AbstractTestCase` and children (`FixturesAwareTestCase` and `WebTestCase`):
- `getFixturesContainer` now has the Symfony `ContainerInterface` and not PSR interface as its return type
- Add `getServiceFromContainer`
- Add `getParameterFromContainer`
- Add `FixturesContainerGetterTrait` to help getting common services from the test container:
- `getConnection` to get a Doctrine DBAL connection
- `getCachePool` to get a CacheItemPoolInterface
- `getElasticsearchClient` to get an Elasticsearch client
- `getHttpClient` to get a Symfony Http client
- Update documentation
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The objective of this PR is to make the bundle support only PHP 8.3 and take advantage of it.
Details
BREAKING CHANGES
kununu/data-fixtures12.0AbstractTestCaseand children (FixturesAwareTestCaseandWebTestCase):getFixturesContainernow has the SymfonyContainerInterfaceand not PSR interface as its return typegetServiceFromContainergetParameterFromContainerFixturesContainerGetterTraitto help getting common services from the test container:getConnectionto get a Doctrine DBAL connectiongetCachePoolto get a CacheItemPoolInterfacegetElasticsearchClientto get an Elasticsearch clientgetHttpClientto get a Symfony Http client