Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(logs): add more info to kuma-validation failure logs #13336

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

slonka
Copy link
Contributor

@slonka slonka commented Apr 7, 2025

Motivation

Closes #13335

Implementation information

Add more info to log message.

Signed-off-by: slonka <slonka@users.noreply.github.com>
@slonka slonka added the ci/skip-test PR: Don't run unit and e2e tests (maybe this is just a doc change) label Apr 7, 2025
@slonka slonka requested a review from a team as a code owner April 7, 2025 07:08
@slonka slonka requested review from bartsmykla and lobkovilya April 7, 2025 07:08
Copy link
Contributor

github-actions bot commented Apr 7, 2025

Reviewer Checklist

🔍 Each of these sections need to be checked by the reviewer of the PR 🔍:
If something doesn't apply please check the box and add a justification if the reason is non obvious.

  • Is the PR title satisfactory? Is this part of a larger feature and should be grouped using > Changelog?
  • PR description is clear and complete. It Links to relevant issue as well as docs and UI issues
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as an image registry)
  • IPv6 is taken into account (.e.g: no string concatenation of host port)
  • Tests (Unit test, E2E tests, manual test on universal and k8s)
    • Don't forget ci/ labels to run additional/fewer tests
  • Does this contain a change that needs to be notified to users? In this case, UPGRADE.md should be updated.
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label)

jijiechen
jijiechen previously approved these changes Apr 7, 2025
@jijiechen
Copy link
Member

/format

Co-authored-by: Jay Jijie Chen <1180092+jijiechen@users.noreply.github.com>
Signed-off-by: Krzysztof Słonka <slonka@users.noreply.github.com>
@slonka
Copy link
Contributor Author

slonka commented Apr 8, 2025

/format

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/skip-test PR: Don't run unit and e2e tests (maybe this is just a doc change)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve warning messages in kuma-validation to help diagnose kuma-cni issues
2 participants