Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(k8s): set allowPrivilegeEscalation to false #13320

Merged
merged 3 commits into from
Apr 7, 2025

Conversation

lukidzi
Copy link
Contributor

@lukidzi lukidzi commented Apr 4, 2025

Motivation

We don't set allowPrivilegeEscalation, but it's unnecessary since our process runs with a different UID, and the kuma-dp container does not require escalation.

Implementation information

Set explicitly allowPrivilegeEscalation to false.

Supporting documentation

Fix #13289

Signed-off-by: Lukasz Dziedziak <lukidzi@gmail.com>
@lukidzi lukidzi requested a review from a team as a code owner April 4, 2025 15:50
@lukidzi lukidzi requested review from Automaat and bartsmykla April 4, 2025 15:50
Copy link
Contributor

github-actions bot commented Apr 4, 2025

Reviewer Checklist

🔍 Each of these sections need to be checked by the reviewer of the PR 🔍:
If something doesn't apply please check the box and add a justification if the reason is non obvious.

  • Is the PR title satisfactory? Is this part of a larger feature and should be grouped using > Changelog?
  • PR description is clear and complete. It Links to relevant issue as well as docs and UI issues
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as an image registry)
  • IPv6 is taken into account (.e.g: no string concatenation of host port)
  • Tests (Unit test, E2E tests, manual test on universal and k8s)
    • Don't forget ci/ labels to run additional/fewer tests
  • Does this contain a change that needs to be notified to users? In this case, UPGRADE.md should be updated.
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label)

Signed-off-by: Lukasz Dziedziak <lukidzi@gmail.com>
bartsmykla
bartsmykla previously approved these changes Apr 7, 2025
@lahabana
Copy link
Contributor

lahabana commented Apr 7, 2025

@lukidzi can we set a note in UPGRADE.md please?

Signed-off-by: Lukasz Dziedziak <lukidzi@gmail.com>
@lukidzi lukidzi merged commit 9258e83 into kumahq:master Apr 7, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set allowPrivilegeEscalation to false for kuma-dp
3 participants