Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kumactl): change mtls backend builtin to provided and skipvalidation #13318

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

lukidzi
Copy link
Contributor

@lukidzi lukidzi commented Apr 4, 2025

Motivation

When a user exports a mesh with the mTLS type set to builtin, it is exported as is. However, this is incorrect when the user attempts to import it.

During import, this mesh should be treated as provided since the secrets are already included. Additionally, applying a builtin mesh triggers the generation of new secrets, even though existing ones are already available.

Implementation information

Simplified the logic for better readability:

  • Ordered resources: MeshSecrets → ... → GlobalSecrets
  • Changed mesh from builtin to provided and added skipValidate to ensure Secret creation can happen after the mesh.
  • Enabled federation test.
  • Fixed Kubernetes export, as skipCreatingInitialPolicies was not being set for the mesh.

Supporting documentation

Fix #13109
Fix: #13217

lukidzi added 4 commits April 3, 2025 15:22
Signed-off-by: Lukasz Dziedziak <lukidzi@gmail.com>
Signed-off-by: Lukasz Dziedziak <lukidzi@gmail.com>
Signed-off-by: Lukasz Dziedziak <lukidzi@gmail.com>
Signed-off-by: Lukasz Dziedziak <lukidzi@gmail.com>
@lukidzi lukidzi added the ci/run-full-matrix PR: Runs all possible e2e test combination (expensive use carefully) label Apr 4, 2025
@lukidzi lukidzi requested a review from a team as a code owner April 4, 2025 14:54
@lukidzi lukidzi requested review from jijiechen and bartsmykla April 4, 2025 14:54
Copy link
Contributor

github-actions bot commented Apr 4, 2025

Reviewer Checklist

🔍 Each of these sections need to be checked by the reviewer of the PR 🔍:
If something doesn't apply please check the box and add a justification if the reason is non obvious.

  • Is the PR title satisfactory? Is this part of a larger feature and should be grouped using > Changelog?
  • PR description is clear and complete. It Links to relevant issue as well as docs and UI issues
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as an image registry)
  • IPv6 is taken into account (.e.g: no string concatenation of host port)
  • Tests (Unit test, E2E tests, manual test on universal and k8s)
    • Don't forget ci/ labels to run additional/fewer tests
  • Does this contain a change that needs to be notified to users? In this case, UPGRADE.md should be updated.
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/run-full-matrix PR: Runs all possible e2e test combination (expensive use carefully)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Federation kubernetes test is flaky Kumaclt export prints Mesh resource twice
1 participant