test(e2e): enabled federation test #13303
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We noticed a flake. I tried to replicate it but was unsuccessful. This issue is strange because, in the test, we use kubectl apply -f config.yaml, which should override the secrets created by the controller. Additionally, apply does not return a conflict (at least, I couldn't reproduce it manually or in the test).
I believe reverting this PR might be a more reliable solution. Here's the sequence of events:
To avoid this race condition, I think we should revert this PR.
Fix #13217