Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(e2e): enabled federation test #13303

Closed
wants to merge 2 commits into from

Conversation

lukidzi
Copy link
Contributor

@lukidzi lukidzi commented Apr 2, 2025

Motivation

We noticed a flake. I tried to replicate it but was unsuccessful. This issue is strange because, in the test, we use kubectl apply -f config.yaml, which should override the secrets created by the controller. Additionally, apply does not return a conflict (at least, I couldn't reproduce it manually or in the test).

I believe reverting this PR might be a more reliable solution. Here's the sequence of events:

  1. The user creates a Mesh with mTLS enabled.
  2. At the same time, the control plane generates a certificate and key for the mesh and the user applies them using kubectl apply -f. This introduces a potential race condition.

To avoid this race condition, I think we should revert this PR.

Fix #13217

Signed-off-by: Lukasz Dziedziak <lukidzi@gmail.com>
@lukidzi lukidzi requested a review from a team as a code owner April 2, 2025 15:56
@lukidzi lukidzi requested review from jijiechen and slonka April 2, 2025 15:56
Copy link
Contributor

github-actions bot commented Apr 2, 2025

Reviewer Checklist

🔍 Each of these sections need to be checked by the reviewer of the PR 🔍:
If something doesn't apply please check the box and add a justification if the reason is non obvious.

  • Is the PR title satisfactory? Is this part of a larger feature and should be grouped using > Changelog?
  • PR description is clear and complete. It Links to relevant issue as well as docs and UI issues
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as an image registry)
  • IPv6 is taken into account (.e.g: no string concatenation of host port)
  • Tests (Unit test, E2E tests, manual test on universal and k8s)
    • Don't forget ci/ labels to run additional/fewer tests
  • Does this contain a change that needs to be notified to users? In this case, UPGRADE.md should be updated.
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label)

Signed-off-by: Lukasz Dziedziak <lukidzi@gmail.com>
@lukidzi lukidzi marked this pull request as draft April 3, 2025 12:10
@lukidzi lukidzi closed this Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant