-
Notifications
You must be signed in to change notification settings - Fork 340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(MeshTimeout): remove if-condition that prevents plugin from running when there are no policies #12769
Conversation
…ng when there are no policies Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
345217b
to
0155b5a
Compare
Reviewer Checklist🔍 Each of these sections need to be checked by the reviewer of the PR 🔍:
|
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Looking at this pr, it looks like we were missing default timeouts? |
Most of the time they're the same as Envoy's defaults. But sometimes they're not and bad case is explained in the issue #12649 |
Motivation
This if-condition at the beginning of the plugin
causes inconsistent default values. For example, the default outbound timeouts should be the same regardless of the presence of MeshTimeout policies with
from
.Implementation information
Depends on #12766
Supporting documentation
Fix #12649