Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(util/labelindex): improve benchmarks to cover labels with two di… #85

Merged
merged 4 commits into from
Feb 18, 2025

Conversation

SOF3
Copy link
Member

@SOF3 SOF3 commented Feb 4, 2025

…mensions

@SOF3 SOF3 requested a review from DeliangFan February 4, 2025 06:11
@codecov-commenter
Copy link

codecov-commenter commented Feb 13, 2025

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 40.98%. Comparing base (a0c9fae) to head (fdb49de).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
util/iter/iter.go 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #85      +/-   ##
==========================================
+ Coverage   40.93%   40.98%   +0.05%     
==========================================
  Files         102      102              
  Lines        7046     7054       +8     
==========================================
+ Hits         2884     2891       +7     
- Misses       4002     4005       +3     
+ Partials      160      158       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SOF3 SOF3 added this pull request to the merge queue Feb 18, 2025
Merged via the queue into kubewharf:main with commit 40b6f6f Feb 18, 2025
5 checks passed
@SOF3 SOF3 deleted the better-bench branch February 18, 2025 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants