ci: Add ci workflow #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viccuad
force-pushed
the
add-ci-workflow
branch
2 times, most recently
from
1287d55 to
42cf392
Compare
jvanz
previously requested changes
Dec 17, 2024
Signed-off-by: Víctor Cuadrado Juan <vcuadradojuan@suse.de>
viccuad
force-pushed
the
add-ci-workflow
branch
from
42cf392 to
e60784e
Compare
|
Added an initial README content as well. |
viccuad
force-pushed
the
add-ci-workflow
branch
from
a6f4bf1 to
8f8291c
Compare
|
@viccuad I've noticed some step names are showing as the first line of the run block, could we assign a clearer name to the affected steps? 
|
Signed-off-by: Víctor Cuadrado Juan <vcuadradojuan@suse.de>
Signed-off-by: Víctor Cuadrado Juan <vcuadradojuan@suse.de>
viccuad
force-pushed
the
add-ci-workflow
branch
from
4f41502 to
1421df7
Compare
|
Slightly reworded readme. |
viccuad
dismissed
jvanz’s stale review
now it correctly points to kubewarden/github-actions(...)@v3.4.0
|
Ready for merge, github-actions v3.4.0 are tagged already. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part of kubewarden/kubewarden-controller#806.
Add ci.yml workflow for PRs, that starts 1 job per policy to be tested, if there's any change inside the policy folder.
Test
This was tested in my viccuad/rego-policies repo.
To see how it looks on a PR:
viccuad/rego-policies#4
Note how there's 2 jobs per policy scheduled, some of them fail, some succeed, all of that expected.
To see how it looks on main:
https://github.com/viccuad/rego-policies/actions/runs/12374488427
Note that the calculate-policy-dirs creates a strategy matrix that is correctly empty, so no follow-up jobs are scheduled.
Additional Information
Tradeoff
Potential improvement