Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rework examples section in the README file. #80

Merged
merged 3 commits into from
Jan 19, 2024

Conversation

jvanz
Copy link
Member

@jvanz jvanz commented Jan 18, 2024

Description

Updates the README file reworking the example section. This commit updates the previous examples updating the commands to deploy the policies and the workloads. As well as adds new example of how the user can skip init container validation.

Related to #73

Updates the README file reworking the example section. This commit
updates the previous examples updating the commands to deploy the
policies and the workloads. As well as adds new example of how the user
can skip init container validation.

Signed-off-by: José Guilherme Vanz <jguilhermevanz@suse.com>
@jvanz jvanz added area/documentation Improvements or additions to documentation kind/enhancement New feature or request labels Jan 18, 2024
@jvanz jvanz self-assigned this Jan 18, 2024
@jvanz jvanz requested a review from a team as a code owner January 18, 2024 17:06
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Member

@viccuad viccuad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just some typos.

Co-authored-by: Víctor Cuadrado Juan <2196685+viccuad@users.noreply.github.com>
Signed-off-by: José Guilherme Vanz <jvanz@jvanz.com>
Copy link

@jhkrug jhkrug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just one suggestion.

README.md Outdated Show resolved Hide resolved
Co-authored-by: John Krug <jh.krug@gmail.com>
Signed-off-by: José Guilherme Vanz <jvanz@jvanz.com>
@jvanz jvanz requested a review from jhkrug January 19, 2024 15:17
Copy link
Member

@flavio flavio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, don't forget to tag a new release once this is merged

@jvanz jvanz merged commit 3618af7 into kubewarden:main Jan 19, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Improvements or additions to documentation kind/enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants