Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Automerge minor,patch PRs in non office hours, enable release-drafter #176

Merged
merged 2 commits into from
Jan 13, 2025

Conversation

viccuad
Copy link
Member

@viccuad viccuad commented Jan 10, 2025

Description

Part of #149.

Test

Additional Information

Tradeoff

Potential improvement

@viccuad viccuad requested a review from a team as a code owner January 10, 2025 13:56
@viccuad viccuad self-assigned this Jan 10, 2025
Signed-off-by: Víctor Cuadrado Juan <vcuadradojuan@suse.de>
Keep major PRs without automerge, and happening early Mondays.

Signed-off-by: Víctor Cuadrado Juan <vcuadradojuan@suse.de>
@viccuad
Copy link
Member Author

viccuad commented Jan 10, 2025

The error is expected as we are adding the config file for the first time: Error: Configuration file .github/release-drafter.yml is not found. The configuration file must reside in your default branch.

Copy link
Member

@flavio flavio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it!

Copy link
Member

@jvanz jvanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I guess the CI is failing because the CI is looking for the file in the default branch. But the file is being added in this PR.

@viccuad viccuad merged commit 6ae5183 into kubewarden:main Jan 13, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants