chore(deps): update to latest version of k8s-objects #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use latest version of k8s-objects. This includes the fix of kubewarden/kubewarden-controller#570 which is required by this policy when mutating resources. Signed-off-by: Flavio Castelli <fcastelli@suse.com>
viccuad
approved these changes
Jan 29, 2024
viccuad
requested changes
Jan 29, 2024
There was a problem hiding this comment.
Wait, this policy is not for public consumption, correct?
If so, we shouldn't add the artifacthub-pkg.yml file, but set in the test workflow input artifacthub: false, see https://github.com/kubewarden/github-actions/blob/main/.github/workflows/reusable-test-policy-go.yml#L6-L10.
This policy is not meant to be published on artifacthub Signed-off-by: Flavio Castelli <fcastelli@suse.com>
flavio
force-pushed
the
update-k8s-objects
branch
from
08ae2f0 to
b7098d4
Compare
|
@viccuad good point. I've updated the PR |
viccuad
approved these changes
Jan 30, 2024
fabriziosestito
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use latest version of k8s-objects. This includes the fix of kubewarden/kubewarden-controller#570 which is required by this policy when mutating resources.