feat: allow set quantities and ignoreValues together. #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To simplify the policy settings validation and void some issues in external UI that uses Kubewarden policies, remove the settings validation the prevents users from defining the `ignoreValues` fields together with the quantities to be validated. Instead of causing and settings validation errors, just ignore the quantities define by the users. Signed-off-by: José Guilherme Vanz <jguilhermevanz@suse.com>
|
@TechDufus are you okay with that? |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To simplify the policy settings validation and void some issues in external UI that uses Kubewarden policies, remove the settings validation the prevents users from defining the
ignoreValuesfields together with the quantities to be validated. Instead of causing and settings validation errors, just ignore the quantities define by the users.Related to the problem mentioned on #29