fix: Set AdmissionRequest{}.RequestKind
#149
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #148.
RequestKind
matches the type of original API request, in the case that there's several kinds that match the same object (e.g: deployments can be modified viaapps/v1
adapps/v1beta1
), and conversion was performed.The
AdmissionRequests
useAdmissionRequest.Kind
to match the rule of the webhook registered for, henceRequestKind
is there for book-keeping.Set
RequestKind
, which gets consumed later on in policy-server to set the metrics baggage:https://github.com/kubewarden/policy-server/blob/63c9f32052b7ced50b4007e8ce0b5ed27392aa7f/src/worker.rs#L226
Test
Built an audit-scanner image with the fix and tested that
kubewarden_policy_evaluations_total
now containresource_kind
:Before:
After:
Didn't add unit tests, as there's not much to do there. Integration tests would be too much.
Additional Information
Tradeoff
Potential improvement