Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MTV-1871] Sorting virtual machines isn't saved while refresh #1464

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jpuzz0
Copy link
Contributor

@jpuzz0 jpuzz0 commented Feb 6, 2025

📝 Links

https://issues.redhat.com/browse/MTV-1871

📝 Description

  • Prevent table refresh (any change to the table - included data updates, or even expanding/collapsing rows as seen in the demos below) from resetting the current active sort selection.
  • Created a common context provider that can be used by other tables to achieve a similar solution if necessary. Since all tables within MTV use the same TableView and ResourceData for sorting, it could be used for any table where the same issue occurs.

🎥 Demo

Before:
https://github.com/user-attachments/assets/56c19f72-d704-407a-8725-03f5a37c8416

After:
https://github.com/user-attachments/assets/72880954-4c42-41fc-95f9-f260796ec047

Signed-off-by: Jeff Puzzo <jpuzzo@redhat.com>
Copy link

sonarqubecloud bot commented Feb 6, 2025

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.32%. Comparing base (13484d0) to head (f69fd6c).
Report is 218 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1464      +/-   ##
==========================================
- Coverage   36.81%   36.32%   -0.50%     
==========================================
  Files         158      156       -2     
  Lines        2548     2522      -26     
  Branches      599      578      -21     
==========================================
- Hits          938      916      -22     
- Misses       1428     1604     +176     
+ Partials      182        2     -180     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jpuzz0 jpuzz0 added the bug Categorizes issue or PR as related to a bug. label Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants