Update the "Max concurrent vm migrations" field descriptions and links #1458
+21
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reference: https://issues.redhat.com/browse/MTV-1212 - Update the "Max concurrent virtual machine migrations" field descriptions, doc reference and edit dialog text within the overview -settings card, based on doc changes https://issues.redhat.com/browse/MTV-1211. - Update the doc references for all other Overview -> settings card fields as well. Signed-off-by: Sharon Gratch <sgratch@redhat.com>
sgratch
force-pushed
the
max-concurrent-vm-migrations-parameter-description-update
branch
from
8115487 to
6cf0ee3
Compare
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1458 +/- ##
==========================================
- Coverage 36.81% 36.32% -0.50%
==========================================
Files 158 156 -2
Lines 2548 2522 -26
Branches 599 603 +4
==========================================
- Hits 938 916 -22
- Misses 1428 1601 +173
+ Partials 182 5 -177 ☔ View full report in Codecov by Sentry. |
|
@RichardHoch - please can you do a review for Sharon of the descriptions and links she has created? |
|
@sgratch LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference: https://issues.redhat.com/browse/MTV-1212
📝 Description
Update the "Max concurrent virtual machine migrations" field descriptions, doc reference and edit dialog text within the overview -settings card, based on doc changes https://issues.redhat.com/browse/MTV-1211.
Update the doc references for all other Overview -> settings card fields as well.
🎥 Demo
📝 CC://
@RichardHoch @anarnold97