[MTV-2003] Secret is loading message is wrong

[jpuzz0]

📝 Links

https://issues.redhat.com/browse/MTV-2003

📝 Description

Don't show loading message when a secret load error exists

🎥 Demo

Before:

After:

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.32%. Comparing base (13484d0) to head (daf8e79).
Report is 218 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1457      +/-   ##
==========================================
- Coverage   36.81%   36.32%   -0.50%     
==========================================
  Files         158      156       -2     
  Lines        2548     2522      -26     
  Branches      599      588      -11     
==========================================
- Hits          938      916      -22     
- Misses       1428     1601     +173     
+ Partials      182        5     -177     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sgratch]

📝 CC://

@RichardHoch @anarnold97 Please review

[RichardHoch]

@sgratch We generally capitalize Secret and write the controller pod as "the forklift-controller pod".

re" "Something is wrong, the secret was not loaded, please try to reload the page."

I'd write "The Secret was not loaded. Try reloading the page." or "The Secret was not loaded. Reload the page." If our error messages usually include "please," go ahead and use it for now, but later it should be removed.

There is no need to say "Something is wrong" if this message only appears when there is a problem. I don't know where else we call this message, so if it appears in a situation when the user might not know something is wrong, then that sentence is OK, in general, but I'd remove it here, if possible.

The text is understandable as is -- this is just a bit of polish.