Avoid running more than one migration concurrently #1454
+65
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reference: https://issues.redhat.com/browse/MTV-1901 Avoid running a migration (start/restart) if a migraiton is already running by disabling/hiding buttons and avoiding adding the migration CR. This will cover cases in which rendering takes few seconds when you use the start/restart action item and then the start/restart button at once. Signed-off-by: Sharon Gratch <sgratch@redhat.com>
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1454 +/- ##
==========================================
- Coverage 36.81% 36.32% -0.50%
==========================================
Files 158 156 -2
Lines 2548 2522 -26
Branches 599 592 -7
==========================================
- Hits 938 916 -22
- Misses 1428 1604 +176
+ Partials 182 2 -180 ☔ View full report in Codecov by Sentry. |
metalice
reviewed
Feb 5, 2025
| const buttonStartLabel = canReStart ? t('Restart migration') : t('Start migration'); | ||
|
|
||
| const [isStartItemEnabled, setIStartItemEnabled] = useState(canStart); |
metalice
reviewed
Feb 5, 2025
| <DropdownItem | ||
| value={1} | ||
| key="start" | ||
| isDisabled={!canStart || !isStartItemEnabled} |
There was a problem hiding this comment.
why also !canStart? u check it on the effect
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference: https://issues.redhat.com/browse/MTV-1901
📝 Description
Avoid running a migration (start/restart) if a migration is already running by disabling/hiding relevant buttons (in page header, actions menu and plan details status page).
Also avoid adding the migration CR to cover cases in which rendering takes few seconds when you use the start/restart action item and then the start/restart button at once.
🎥 Demo
Before
Screencast.from.2025-02-05.12-10-40.webm
After
Screencast.from.2025-02-05.12-06-55.webm