MTV-1727: Provide disabled reason with tooltip on Cancel and Remove VMs buttons #1453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Ms buttons Signed-off-by: Joachim Schuler <jschuler@redhat.com>
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1453 +/- ##
==========================================
- Coverage 36.81% 36.32% -0.50%
==========================================
Files 158 156 -2
Lines 2548 2522 -26
Branches 599 594 -5
==========================================
- Hits 938 916 -22
+ Misses 1428 1424 -4
Partials 182 182 ☔ View full report in Codecov by Sentry. |
metalice
reviewed
Feb 5, 2025
...le-plugin/src/modules/Plans/views/details/tabs/VirtualMachines/modals/PlanVMsDeleteModal.tsx
Outdated
Show resolved
Hide resolved
metalice
reviewed
Feb 5, 2025
...src/modules/Plans/views/details/tabs/VirtualMachines/components/MigrationVMsCancelButton.tsx
Outdated
Show resolved
Hide resolved
metalice
reviewed
Feb 5, 2025
...ugin/src/modules/Plans/views/details/tabs/VirtualMachines/components/PlanVMsDeleteButton.tsx
Outdated
Show resolved
Hide resolved
metalice
reviewed
Feb 5, 2025
...ugin/src/modules/Plans/views/details/tabs/VirtualMachines/components/PlanVMsDeleteButton.tsx
Outdated
Show resolved
Hide resolved
…ls/tabs/VirtualMachines/components/PlanVMsDeleteButton.tsx Co-authored-by: Matan Schatzman <matanschatzman@gmail.com> Signed-off-by: Joachim Schuler <jdh.schuler@gmail.com>
Signed-off-by: Joachim Schuler <jschuler@redhat.com>
|
sgratch
changed the title
metalice
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Links
https://issues.redhat.com/browse/MTV-1727
📝 Description
Adds a tooltip to the Cancel / Remove VMs buttons if there is a reason
🎥 Demo
Archived migration plan:
Ready migration plan:
Screen.Recording.2025-02-04.at.1.23.47.PM.mov
Running migration plan:
📝 CC://