From b8f03ac36e3ec28ac4829c93858cbc5509879714 Mon Sep 17 00:00:00 2001 From: Sharon Gratch Date: Wed, 5 Feb 2025 21:16:35 +0200 Subject: [PATCH] Replace VDDK image hint sections with rephrased warning alert sections Reference: https://issues.redhat.com/browse/MTV-1783 Replace VDDK image hint sections with warning alert sections and rephrased the text to emphasize the importance of setting VDDK image value from performace reasons. Trying to be aligned with doc https://issues.redhat.com/browse/MTV-1782. Signed-off-by: Sharon Gratch --- .../en/plugin__forklift-console-plugin.json | 2 +- .../EditProviderVDDKImage.tsx | 29 ++++++++---------- .../VDDKHelperText/VDDKHelperText.tsx | 9 ++++-- .../provider/vsphere/validateVDDKImage.ts | 4 +-- .../vsphere/vsphereProviderValidator.ts | 2 +- .../components/EsxiProviderCreateForm.tsx | 29 ++++++++---------- .../components/VCenterProviderCreateForm.tsx | 30 +++++++++---------- .../components/VDDKDetailsItem.tsx | 3 +- 8 files changed, 52 insertions(+), 56 deletions(-) diff --git a/packages/forklift-console-plugin/locales/en/plugin__forklift-console-plugin.json b/packages/forklift-console-plugin/locales/en/plugin__forklift-console-plugin.json index 3db6e8b6e..7a6e2265f 100644 --- a/packages/forklift-console-plugin/locales/en/plugin__forklift-console-plugin.json +++ b/packages/forklift-console-plugin/locales/en/plugin__forklift-console-plugin.json @@ -440,7 +440,7 @@ "Show archived": "Show archived", "Show the welcome card": "Show the welcome card", "Skip certificate validation": "Skip certificate validation", - "Skip VMware Virtual Disk Development Kit (VDDK) SDK acceleration (migration might be slow).": "Skip VMware Virtual Disk Development Kit (VDDK) SDK acceleration (migration might be slow).", + "Skip VMware Virtual Disk Development Kit (VDDK) SDK acceleration (not recommended).": "Skip VMware Virtual Disk Development Kit (VDDK) SDK acceleration (not recommended).", "Snapshot polling interval (seconds)": "Snapshot polling interval (seconds)", "Some VMs Failed": "Some VMs Failed", "Something is wrong, the data was not loaded due to an error, please try to reload the page.": "Something is wrong, the data was not loaded due to an error, please try to reload the page.", diff --git a/packages/forklift-console-plugin/src/modules/Providers/modals/EditProviderVDDKImage/EditProviderVDDKImage.tsx b/packages/forklift-console-plugin/src/modules/Providers/modals/EditProviderVDDKImage/EditProviderVDDKImage.tsx index 641a2542b..bae61c579 100644 --- a/packages/forklift-console-plugin/src/modules/Providers/modals/EditProviderVDDKImage/EditProviderVDDKImage.tsx +++ b/packages/forklift-console-plugin/src/modules/Providers/modals/EditProviderVDDKImage/EditProviderVDDKImage.tsx @@ -3,7 +3,7 @@ import { useForkliftTranslation } from 'src/utils/i18n'; import { Modify, ProviderModel, V1beta1Provider } from '@kubev2v/types'; import { K8sModel } from '@openshift-console/dynamic-plugin-sdk'; -import { Checkbox, Hint, HintBody, TextInput } from '@patternfly/react-core'; +import { Alert, Checkbox, TextInput } from '@patternfly/react-core'; import { VDDKHelperTextShort } from '../../utils/components/VDDKHelperText'; import { validateVDDKImage } from '../../utils/validators'; @@ -46,21 +46,18 @@ export const EditProviderVDDKImage: React.FC = (prop }; const body = ( - - - - onChange(v, e)} - id="emptyVddkInitImage" - name="emptyVddkInitImage" - /> - - + }> + onChange(v, e)} + id="emptyVddkInitImage" + name="emptyVddkInitImage" + /> + ); return ( diff --git a/packages/forklift-console-plugin/src/modules/Providers/utils/components/VDDKHelperText/VDDKHelperText.tsx b/packages/forklift-console-plugin/src/modules/Providers/utils/components/VDDKHelperText/VDDKHelperText.tsx index fe3fbd5c2..2910757ea 100644 --- a/packages/forklift-console-plugin/src/modules/Providers/utils/components/VDDKHelperText/VDDKHelperText.tsx +++ b/packages/forklift-console-plugin/src/modules/Providers/utils/components/VDDKHelperText/VDDKHelperText.tsx @@ -13,12 +13,14 @@ export const VDDKHelperText: React.FC = () => (

The Migration Toolkit for Virtualization (MTV) uses the VMware Virtual Disk Development Kit (VDDK) SDK to accelerate transferring virtual disks from VMware vSphere. Therefore, creating a - VDDK image, although optional, is highly recommended. + VDDK image, although optional, is highly recommended. Using MTV without VDDK is not + recommended and could result in significantly lower migration speeds


- To accelerate migrations, we recommend to create a VDDK init image. Learn more about{' '} + To accelerate migration and reduce the risk of a plan failing, it is strongly recommended to + create a VDDK init image. Learn more about{' '} Creating a VDDK image @@ -30,7 +32,8 @@ export const VDDKHelperText: React.FC = () => ( export const VDDKHelperTextShort: React.FC = () => (

- To accelerate migrations, we recommend to create a VDDK init image. Learn more about{' '} + It is strongly recommended to use a VDDK image. Not using a VDDK image could result in + significantly lower migration speeds or a plan failing. For more information, see{' '} Creating a VDDK image diff --git a/packages/forklift-console-plugin/src/modules/Providers/utils/validators/provider/vsphere/validateVDDKImage.ts b/packages/forklift-console-plugin/src/modules/Providers/utils/validators/provider/vsphere/validateVDDKImage.ts index 2d49bee62..cb0dd62c9 100644 --- a/packages/forklift-console-plugin/src/modules/Providers/utils/validators/provider/vsphere/validateVDDKImage.ts +++ b/packages/forklift-console-plugin/src/modules/Providers/utils/validators/provider/vsphere/validateVDDKImage.ts @@ -4,7 +4,7 @@ export const validateVDDKImage = (vddkImage: string | number): ValidationMsg => // For a newly opened form where the field is not set yet, set the validation type to default. if (vddkImage === undefined) return { - msg: 'The VDDK image is empty. It is recommended to provide an image in the format of /vddk: .', + msg: 'The VDDK image is empty. It is strongly recommended to provide an image using the following format: /vddk: .', type: 'default', }; @@ -18,7 +18,7 @@ export const validateVDDKImage = (vddkImage: string | number): ValidationMsg => if (trimmedVddkImage === '') return { - msg: 'The VDDK image is empty. It is recommended to provide an image in the format of /vddk: .', + msg: 'The VDDK image is empty. It is strongly recommended to provide an image using the following format: /vddk: .', type: 'error', }; diff --git a/packages/forklift-console-plugin/src/modules/Providers/utils/validators/provider/vsphere/vsphereProviderValidator.ts b/packages/forklift-console-plugin/src/modules/Providers/utils/validators/provider/vsphere/vsphereProviderValidator.ts index 6447e6064..567bab130 100644 --- a/packages/forklift-console-plugin/src/modules/Providers/utils/validators/provider/vsphere/vsphereProviderValidator.ts +++ b/packages/forklift-console-plugin/src/modules/Providers/utils/validators/provider/vsphere/vsphereProviderValidator.ts @@ -22,7 +22,7 @@ export function vsphereProviderValidator(provider: V1beta1Provider): ValidationM if (emptyVddkInitImage === 'yes' && vddkInitImage === '') { return { - msg: 'The VDDK image is empty. It is recommended to provide an image in the format of /vddk: .', + msg: 'The VDDK image is empty. It is strongly recommended to provide an image using the following format: /vddk: .', type: 'warning', }; } diff --git a/packages/forklift-console-plugin/src/modules/Providers/views/create/components/EsxiProviderCreateForm.tsx b/packages/forklift-console-plugin/src/modules/Providers/views/create/components/EsxiProviderCreateForm.tsx index af203b312..1fdae03d9 100644 --- a/packages/forklift-console-plugin/src/modules/Providers/views/create/components/EsxiProviderCreateForm.tsx +++ b/packages/forklift-console-plugin/src/modules/Providers/views/create/components/EsxiProviderCreateForm.tsx @@ -9,7 +9,7 @@ import { useForkliftTranslation } from 'src/utils/i18n'; import { FormGroupWithHelpText } from '@kubev2v/common'; import { V1beta1Provider } from '@kubev2v/types'; -import { Checkbox, Form, Hint, HintBody, Popover, Radio, TextInput } from '@patternfly/react-core'; +import { Alert, Checkbox, Form, Popover, Radio, TextInput } from '@patternfly/react-core'; import HelpIcon from '@patternfly/react-icons/dist/esm/icons/help-icon'; export interface EsxiProviderCreateFormProps { provider: V1beta1Provider; @@ -210,21 +210,18 @@ export const EsxiProviderCreateForm: React.FC = ({ } > - - - - onChangEmptyVddk(v, e)} - id="emptyVddkInitImage" - name="emptyVddkInitImage" - /> - - + }> + onChangEmptyVddk(v, e)} + id="emptyVddkInitImage" + name="emptyVddkInitImage" + /> +

} > - - - - onChangEmptyVddk(v, e)} - id="emptyVddkInitImage" - name="emptyVddkInitImage" - /> - - + }> + onChangEmptyVddk(v, e)} + id="emptyVddkInitImage" + name="emptyVddkInitImage" + /> + +
= ({ valid container image path in the format of{' '} registry_route_or_server_path/vddk:‹tag›.

- To accelerate migrations, we recommend to specify a VDDK init image. + To accelerate migration and reduce the risk of a plan failing, it is strongly recommended to + specify a VDDK init image. );