bugfix: dont throw error if +required is set with omitempty #455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexzielenski The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
Jefftree
reviewed
Feb 23, 2024
alexzielenski
force-pushed
the
required-bugfix
branch
from
5b141d2 to
ad6031a
Compare
Jefftree
reviewed
Feb 23, 2024
Jefftree
reviewed
Feb 23, 2024
alexzielenski
force-pushed
the
required-bugfix
branch
from
b57289a to
2980c8a
Compare
|
added another commit to fix another bug that was exposed when i pulled the changes into k/k. Newly evaluated enums sometimes alias each other and cause duplicate entries. |
Jefftree
reviewed
Feb 23, 2024
previous PR had a bug
alexzielenski
force-pushed
the
required-bugfix
branch
from
2980c8a to
862dda8
Compare
Jefftree
reviewed
Feb 23, 2024
alexzielenski
force-pushed
the
required-bugfix
branch
from
862dda8 to
649db69
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had included a bug into previous PR #448 which throws an error if +required is set on an
omitemptyfield which ran counter to my interests.Took another stab at it, this time including tests :)
/assign @Jefftree
sorry for the churn.
/hold
Am also going to try to pin dep after this one so will wait for green PR there before merging this