bugfix: emit enum in schema when used as list or map element #454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexzielenski The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
|
/lgtm What kind of changes were you thinking? Emitting additional validation information in the OpenAPI seems like a net positive to me. |
k8s-ci-robot
added
do-not-merge/hold
|
/hold cancel I meant that the code generator feels like it could use a refactor. It is very painful to add/maintain features |
k8s-ci-robot
removed
the
do-not-merge/hold
alexzielenski
added a commit
to alexzielenski/kube-openapi
that referenced
this pull request
Feb 23, 2024
kubernetes#454 caused new enums to be emitted which exposed this bug. Some enums are aliases of others and redeclare their enum cases. This change causes duplicate eunm cases to be ignored
alexzielenski
added a commit
to alexzielenski/kube-openapi
that referenced
this pull request
Feb 23, 2024
kubernetes#454 caused new enums to be emitted which exposed this bug. Some enums are aliases of others and redeclare their enum cases. This change causes duplicate eunm cases to be ignored
alexzielenski
added a commit
to alexzielenski/kube-openapi
that referenced
this pull request
Feb 23, 2024
kubernetes#454 caused new enums to be emitted which exposed this bug. Some enums are aliases of others and redeclare their enum cases. This change causes duplicate eunm cases to be ignored
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #450
Doing this I feel like we are getting closer to need a refactor since when we add a feature there is so much conditional code we end up missing spots. But I am wondering how tolerant we are of possibly changing the generated schema?
/assign @Jefftree