Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable HTTP/2 by Default for Metrics endpoint to Mitigate CVE Risks #11764

Open
anshuman-agarwala opened this issue Jan 28, 2025 · 4 comments
Open

Disable HTTP/2 by Default for Metrics endpoint to Mitigate CVE Risks #11764

anshuman-agarwala opened this issue Jan 28, 2025 · 4 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-priority Indicates an issue lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@anshuman-agarwala
Copy link

What would you like to be added (User Story)?

There is a security vulnerability in golang/net which can allow malicious authorized clients to DOS the kube-apiserver.
More information can be found in kubernetes/kubernetes#121197

Detailed Description

The workaround for this issue that other projects have adopted is to make http/2 optional using a flag.
More information about the cve:
GHSA-qppj-fm5r-hxr3
GHSA-4374-p667-p6c8

Anything else you would like to add?

No response

Label(s) to be applied

/kind feature
One or more /area label. See https://github.com/kubernetes-sigs/cluster-api/labels?q=area for the list of labels.
@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. needs-priority Indicates an issue lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 28, 2025
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If CAPI contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@sbueringer
Copy link
Member

Wondering if this should be discussed on the controller-runtime level

@anshuman-agarwala
Copy link
Author

Hi @sbueringer,
Shall I open the same issue in controller-runtime?

@sbueringer
Copy link
Member

sbueringer commented Jan 29, 2025 •
edited
Loading

I think that would be good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-priority Indicates an issue lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sbueringer @k8s-ci-robot @anshuman-agarwala