Cherry-pick #696 tests: tweak timings so we cancel during HTTP processing #702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are 3 possibilities: * We cancel before the HTTP request (possibly even before the dial has completed) * We cancel during the delay in our slow server * We cancel after request processing Because our intervals were [0, 1s] and [0.5s, 2s] I think we previously could have hit all three cases. Likely there is a bug lurking in one of these three cases, but let's start by making the delays such that we are always in the second situation (assuming dialing localhost takes < 1s) We now delay the HTTP response by 3 seconds, and cancel after a random value in the interval [1s, 2s)
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
|
/assign @justinsb |
|
/approve |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cheftako, justinsb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git branch -f release-0.31 upstream/release-0.31
git checkout release-0.31
git cherry-pick ea4e1e6
There are 3 possibilities:
Because our intervals were [0, 1s] and [0.5s, 2s] I think we previously could have hit all three cases.
Likely there is a bug lurking in one of these three cases, but let's start by making the delays such that we are always in the second situation (assuming dialing localhost takes < 1s)
We now delay the HTTP response by 3 seconds, and cancel after a random value in the interval [1s, 2s)