Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switching to a longer test timeout. #690

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Switching to a longer test timeout. #690

wants to merge 1 commit into from

Conversation

cheftako
Copy link
Contributor

Github actions seem significantly under resourced. As a result we get a high level of flakes where CPU starved goroutines are not completing inside of 30 seconds.

@cheftako
Switching to a longer test timeout.
f620421 
Github actions seem significantly under resourced.
As a result we get a high level of flakes where CPU
starved goroutines are not completing inside of 30 seconds.
@cheftako cheftako requested a review from tallclair January 17, 2025 20:27
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheftako

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from ipochi January 17, 2025 20:27
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 17, 2025
@cheftako
Copy link
Contributor Author

/test pull-apiserver-network-proxy-test-master

1 similar comment
@cheftako
Copy link
Contributor Author

/test pull-apiserver-network-proxy-test-master

@k8s-ci-robot
Copy link
Contributor

@cheftako: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-apiserver-network-proxy-test-master f620421 link true /test pull-apiserver-network-proxy-test-master

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jkh52
Copy link
Contributor

jkh52 commented Jan 22, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 22, 2025
tallclair
tallclair reviewed Jan 22, 2025
View reviewed changes
tests/framework/util.go
)

var ForeverTestTimeout = time.Minute
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: const

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tallclair tallclair tallclair left review comments

@ipochi ipochi Awaiting requested review from ipochi

Assignees

@jkh52 jkh52

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cheftako @k8s-ci-robot @jkh52 @tallclair