Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added debug to apparent stop channel called early. #687

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added debug to apparent stop channel called early. #687

wants to merge 1 commit into from

Conversation

cheftako
Copy link
Contributor

No description provided.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheftako

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 10, 2025
@cheftako
Copy link
Contributor Author

/test pull-apiserver-network-proxy-test-master

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 14, 2025
@cheftako
Copy link
Contributor Author

/assign @tallclair

tallclair
tallclair reviewed Jan 14, 2025
View reviewed changes
pkg/agent/client.go Outdated Show resolved Hide resolved
tallclair
tallclair reviewed Jan 15, 2025
View reviewed changes
pkg/agent/client.go Outdated Show resolved Hide resolved
pkg/agent/client.go Outdated Show resolved Hide resolved
tallclair
tallclair reviewed Jan 15, 2025
View reviewed changes
cmd/agent/app/server.go Outdated Show resolved Hide resolved
@cheftako
Added code to improve timeout on blocked read.
91a882e 
Fixing unused change.
Added test for deadline occurring.
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 17, 2025
@cheftako
Copy link
Contributor Author

/test pull-apiserver-network-proxy-test-master

@cheftako
Copy link
Contributor Author

Original blocking issue seems to have at least temporarily gone away.
Putting a hold on this until the issue comes back.
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 17, 2025
@cheftako
Copy link
Contributor Author

/unhold
Original problem is back. Attempts to extend timeout aren't working. Now we are seeing the problem on TestProxyDial_RequestCancelled_Concurrent_GRPC. These are blocking on the same read call.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tallclair tallclair tallclair left review comments

@elmiko elmiko Awaiting requested review from elmiko

Assignees

@tallclair tallclair

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cheftako @k8s-ci-robot @tallclair