Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Authz support for Azure #252

Closed
wants to merge 9 commits into from
Closed

Adding Authz support for Azure #252

wants to merge 9 commits into from

Conversation

krdhruva
Copy link
Contributor

@krdhruva krdhruva commented May 19, 2020 •
edited
Loading

Adding Authz support for Azure for both AKS and ARC scenarios.
This PR contains cli, code and doc changes. I will raise separate PR for doc changes.

This implements #237

@krdhruva krdhruva marked this pull request as ready for review May 20, 2020 05:08
@krdhruva krdhruva marked this pull request as draft May 20, 2020 05:19
@krdhruva krdhruva marked this pull request as ready for review May 20, 2020 05:21
@krdhruva
Copy link
Contributor Author

@weinong , @tamalsaha can you please take a look?

@tamalsaha
Copy link
Contributor

tamalsaha commented May 20, 2020 •
edited
Loading

Thanks @krdhruva .

  1. Can you please rebase on master? I see a number of changes in Makefile and CI files that were already done on master.

  2. I see that you have updated the k8s.io/api to v0.18.2 . Was that intentional? If yes, I wonder if that change should be done separately so that it is easy to see actual changes done to support authZ webhook. Also, I think for v0.18.2, we don't need the replace section in go.mod anymore since Kubernetes supports go mod now.

@tamalsaha tamalsaha self-requested a review May 20, 2020 07:36
@Anumita Anumita force-pushed the master branch 2 times, most recently from 9138bde to 6ade314 Compare May 20, 2020 18:17
@tamalsaha
Update to Kubernetes 1.18.3 (kubeguard#253)
e796de2 
Signed-off-by: Tamal Saha <tamal@appscode.com>
@tamalsaha
Copy link
Contributor

@krdhruva , I have upgraded master to use k8s v0.18.3 #253 . Please rebase and squash again.

tamalsaha added 2 commits May 21, 2020 07:59
@tamalsaha
Use appscode/golang-dev:1.4 image
587f76c 
Signed-off-by: Tamal Saha <tamal@appscode.com>
@tamalsaha
Fix linter warnings (kubeguard#254)
2051609 
Signed-off-by: Tamal Saha <tamal@appscode.com>
weinong
weinong reviewed May 21, 2020
View reviewed changes
weinong
weinong reviewed May 21, 2020
View reviewed changes
tamalsaha and others added 6 commits May 22, 2020 02:44
@tamalsaha
Update dependencies
ed6cf0a 
Signed-off-by: Tamal Saha <tamal@appscode.com>
@krdhruva @Anumita
Adding Authz support for Azure
560d27a 
Signed-off-by: Krupesh Dhruva <krdhruva@microsoft.com>
Signed-off-by: Ubuntu <ansheno_ppk@anshenoVM.da12rmhqn3xunlrjlf1ytzev1d.bx.internal.cloudapp.net>
@Anumita
Reverted unnecessary go.mod changes
da2ae2b 
Signed-off-by: Anumita <ansheno@microsoft.com>
Signed-off-by: Ubuntu <ansheno_ppk@anshenoVM.da12rmhqn3xunlrjlf1ytzev1d.bx.internal.cloudapp.net>
@krdhruva @Anumita
Doc changes for Azure authorization support (#6)
80de593 
* Doc changes for Azure authorization support
@Anumita
Replacing auth with authn in webhok_config.go
062aa5a
reverting go.mod changes
149cb59
@krdhruva
Copy link
Contributor Author

Closing this PR due to conflict on rebase. Opening a new PR.

@krdhruva krdhruva closed this May 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weinong weinong weinong left review comments

@tamalsaha tamalsaha Awaiting requested review from tamalsaha

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@krdhruva @tamalsaha @weinong @Anumita