Skip to content

feat(ws): add frontend hooks to call create WS backend #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: notebooks-v2
Choose a base branch
from

Conversation

YosiElias
Copy link
Member

@YosiElias YosiElias commented Feb 20, 2025

Implement call to backend to create workspace as part of #57

Tested with this field & data (according to the readme of backend):

    {
    data: {
      name: 'dora',
      paused: false,
      defer_updates: false,
      kind: 'jupyterlab',
      pod_template: {
        pod_metadata: {
          labels: {
            app: 'dora',
          },
          annotations: {
            app: 'dora',
          },
        },
        volumes: {
          home: 'workspace-home-bella',
          data: [
            {
              pvc_name: 'workspace-data-bella',
              mount_path: '/data/my-data',
              read_only: false,
            },
          ],
        },
        options: {
          image_config: 'jupyterlab_scipy_190',
          pod_config: 'tiny_cpu',
        },
      },
    },
  }

Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign ederign for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@YosiElias YosiElias changed the title Create workspace call to bff feat(ws): Notebooks 2.0 // Frontend // Call To Create Workspace Feb 20, 2025
Signed-off-by: Yossi Elias (EXT-Nokia) <yossi.elias.ext@nokia.com>
@YosiElias YosiElias force-pushed the create-workspace-call branch from 1efc32b to 5355279 Compare February 20, 2025 15:03
@ederign
Copy link
Member

ederign commented Feb 27, 2025

/assign @paulovmr

@thesuperzapper thesuperzapper changed the title feat(ws): Notebooks 2.0 // Frontend // Call To Create Workspace feat(ws): add frontend hooks to call create WS backend Feb 27, 2025
@paulovmr
Copy link

Hi @YosiElias , could you please rebase this PR after the API changes? Thanks!

@senanz
Copy link

senanz commented Apr 21, 2025

/assign

@senanz
Copy link

senanz commented Apr 21, 2025

@paulovmr - PR rebased

@paulovmr
Copy link

/ok-to-test

createWorkspace: CreateWorkspace;
};

export type PodTemplate = {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The JSON field names were changed to camelCase in this PR: #214

Please consider adding this type in the workspaces/frontend/src/shared/types.ts file, with the name WorkspacePodTemplate, and use it in the podTemplate field of the Workspace type.

};
};

export type CreateWorkspaceData = {
Copy link

@paulovmr paulovmr Apr 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was changed to camelCase as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Needs Triage
Development

Successfully merging this pull request may close these issues.

4 participants