-
Notifications
You must be signed in to change notification settings - Fork 42
feat(ws): add frontend hooks to call create WS backend #217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: notebooks-v2
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Yossi Elias (EXT-Nokia) <yossi.elias.ext@nokia.com>
1efc32b
to
5355279
Compare
/assign @paulovmr |
Hi @YosiElias , could you please rebase this PR after the API changes? Thanks! |
/assign |
@paulovmr - PR rebased |
/ok-to-test |
createWorkspace: CreateWorkspace; | ||
}; | ||
|
||
export type PodTemplate = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The JSON field names were changed to camelCase in this PR: #214
Please consider adding this type in the workspaces/frontend/src/shared/types.ts
file, with the name WorkspacePodTemplate
, and use it in the podTemplate
field of the Workspace
type.
}; | ||
}; | ||
|
||
export type CreateWorkspaceData = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was changed to camelCase as well.
Implement call to backend to create workspace as part of #57
Tested with this field & data (according to the readme of backend):