Make security context defaulting functions publicly accessible #1395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sayedppqq
force-pushed
the
pg-funcs-public
branch
from
36829fd to
253cbc8
Compare
ArnobKumarSaha
requested changes
Feb 12, 2025
Signed-off-by: sayedppqq <sayed@appscode.com>
sayedppqq
force-pushed
the
pg-funcs-public
branch
from
253cbc8 to
5ec720c
Compare
ArnobKumarSaha
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the
apis/kubedb/v1andapis/kubedb/v1alpha2directories, primarily focused on renaming functions for consistency and updating default values. The most important changes include renaming functions to use PascalCase, updating default values, and modifying how secrets are referenced.Function renaming for consistency:
apis/kubedb/v1/mongodb_helpers.go: RenamedsetDefaultPodSecurityContexttoSetDefaultPodSecurityContextto use PascalCase. [1] [2]apis/kubedb/v1/postgres_helpers.go: Renamed multiple functions to use PascalCase, includingsetDefaultPodSecurityContext,setInitContainerDefaults,setPostgresContainerDefaults, andsetCoordinatorContainerDefaults. [1] [2] [3] [4] [5]Updating default values:
apis/kubedb/v1alpha2/ferretdb_helpers.go: Updated the default version from13.13to13.13-bookworm.Modifying secret references:
apis/kubedb/v1alpha2/ferretdb_helpers.go: Modified theGetPersistentSecretsfunction to useGetAuthSecretNameinstead of directly accessingf.Spec.AuthSecret.Name.