Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set maxscale Field Optional #1389

Merged
merged 1 commit into from
Jan 30, 2025
Merged

Set maxscale Field Optional #1389

merged 1 commit into from
Jan 30, 2025

Conversation

sheikh-arman
Copy link
Contributor

Signed-off-by: SK Ali Arman arman@appscode.com

@sheikh-arman
Make maxscale Field Optional
75c9cd5 
Signed-off-by: SK Ali Arman <arman@appscode.com>
@sheikh-arman sheikh-arman changed the title Make maxscale Field Optional Set maxscale Field Optional Jan 30, 2025
raihankhan
raihankhan approved these changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@raihankhan raihankhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@raihankhan raihankhan added the automerge Kodiak will auto merge PRs that have this label label Jan 30, 2025
@kodiak-appscode kodiak-appscode bot merged commit e37dc98 into master Jan 30, 2025
11 checks passed
@kodiak-appscode kodiak-appscode bot deleted the fix-api branch January 30, 2025 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raihankhan raihankhan raihankhan approved these changes

Assignees
No one assigned
Labels
automerge Kodiak will auto merge PRs that have this label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sheikh-arman @raihankhan