Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Common AuthSecret Name #1333

Merged
merged 8 commits into from
Oct 31, 2024
Merged

Fix Common AuthSecret Name #1333

merged 8 commits into from
Oct 31, 2024

Conversation

raihankhan
Copy link
Contributor

No description provided.

ArnobKumarSaha
ArnobKumarSaha requested changes Oct 25, 2024
View reviewed changes
Copy link
Member

@ArnobKumarSaha ArnobKumarSaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kafka ?

arnob@office ~> kubectl get secrets -n demo | grep kafka-
kafka-test-admin-cred                 kubernetes.io/basic-auth   2      5h21m
kafka-test-config                     Opaque                     2      5h21m

@obaydullahmhs
Copy link
Member

Already opened a PR: #1331

tapojit047
tapojit047 requested changes Oct 28, 2024
View reviewed changes
pritamdas99
pritamdas99 previously approved these changes Oct 28, 2024
View reviewed changes
Copy link
Member

@pritamdas99 pritamdas99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

sheikh-arman
sheikh-arman reviewed Oct 29, 2024
View reviewed changes
Copy link
Contributor

@sheikh-arman sheikh-arman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

tapojit047
tapojit047 previously approved these changes Oct 29, 2024
View reviewed changes
Copy link
Member

@tapojit047 tapojit047 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

ArnobKumarSaha
ArnobKumarSaha requested changes Oct 29, 2024
View reviewed changes
apis/kubedb/v1alpha2/solr_helpers.go
Comment on lines -265 to -268
if s.Spec.AuthSecret == nil {
s.Spec.AuthSecret = &v1.LocalObjectReference{
Name: s.SolrSecretName("admin-cred"),
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We dont need the authSecret defaulting ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no
a method is added to retrieve the name of auth secret.

raihankhan and others added 8 commits October 31, 2024 10:23
@raihankhan @obaydullahmhs
Fix common authsecret name
a9ba6bb 
Signed-off-by: raihankhan <raihan@appscode.com>
@obaydullahmhs
Fix Kafka default auth-secret name (#1331)
78312bc 
Signed-off-by: obaydullahmhs <obaydullah@appscode.com>
@raihankhan @obaydullahmhs
Fix druid
b545088 
Signed-off-by: raihankhan <raihan@appscode.com>
@tapojit047 @obaydullahmhs
Update druid
8da8a46 
Signed-off-by: Tapajit Chandra Paul <tapajit@appscode.com>
@pritamdas99 @obaydullahmhs
Update persistent secret name
56660f6 
Signed-off-by: pritamdas99 <pritam@appscode.com>
@pritamdas99 @obaydullahmhs
Add authsecret in persistent secret list
0aeb3a6 
Signed-off-by: pritamdas99 <pritam@appscode.com>
@tapojit047 @obaydullahmhs
Update druid ssl
706d75f 
Signed-off-by: Tapajit Chandra Paul <tapajit@appscode.com>
@obaydullahmhs
Add GetKeystoreSecretName method for kafka and connect
bd7bff6 
Signed-off-by: obaydullahmhs <obaydullah@appscode.com>
@raihankhan raihankhan merged commit 3b38a01 into master Oct 31, 2024
11 checks passed
@raihankhan raihankhan deleted the fix-authname branch October 31, 2024 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sheikh-arman sheikh-arman sheikh-arman left review comments

@pritamdas99 pritamdas99 pritamdas99 left review comments

@ArnobKumarSaha ArnobKumarSaha ArnobKumarSaha requested changes

@tapojit047 tapojit047 tapojit047 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@raihankhan @obaydullahmhs @tapojit047 @sheikh-arman @ArnobKumarSaha @pritamdas99