-
Notifications
You must be signed in to change notification settings - Fork 21
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add MS SQL Server Arbiter APIs (#1363)
Signed-off-by: Neaj Morshad <neaj@appscode.com> Signed-off-by: Arnob kumar saha <arnob@appscode.com> Co-authored-by: Arnob kumar saha <arnob@appscode.com>
- Loading branch information
1 parent
affa6dc
commit 7ad4392
Showing
10 changed files
with
325 additions
and
30 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,203 @@ | ||
| /* | ||
| Copyright AppsCode Inc. and Contributors | ||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
|
|
||
| package apis | ||
|
|
||
| import ( | ||
| "testing" | ||
|
|
||
| core "k8s.io/api/core/v1" | ||
| "k8s.io/apimachinery/pkg/api/resource" | ||
| ) | ||
|
|
||
| var DefaultResources = core.ResourceRequirements{ | ||
| Requests: core.ResourceList{ | ||
| core.ResourceCPU: resource.MustParse("1"), | ||
| core.ResourceMemory: resource.MustParse("2Gi"), | ||
| }, | ||
| Limits: core.ResourceList{ | ||
| core.ResourceCPU: resource.MustParse("2"), | ||
| core.ResourceMemory: resource.MustParse("4Gi"), | ||
| }, | ||
| } | ||
|
|
||
| func TestSetDefaultResourceLimits(t *testing.T) { | ||
| type args struct { | ||
| req *core.ResourceRequirements | ||
| defaultResources core.ResourceRequirements | ||
| } | ||
| tests := []struct { | ||
| name string | ||
| args args | ||
| }{ | ||
| { | ||
| name: "Both the requests and limits are set", | ||
| args: args{ | ||
| req: &core.ResourceRequirements{ | ||
| Requests: core.ResourceList{ | ||
| core.ResourceCPU: resource.MustParse(".500"), | ||
| core.ResourceMemory: resource.MustParse("1Gi"), | ||
| }, | ||
| Limits: core.ResourceList{ | ||
| core.ResourceCPU: resource.MustParse("1"), | ||
| core.ResourceMemory: resource.MustParse("2Gi"), | ||
| }, | ||
| }, | ||
| defaultResources: DefaultResources, | ||
| }, | ||
| }, | ||
| { | ||
| name: "Only requests are set - limits should be set from requests", | ||
| args: args{ | ||
| req: &core.ResourceRequirements{ | ||
| Requests: core.ResourceList{ | ||
| core.ResourceCPU: resource.MustParse(".500"), | ||
| core.ResourceMemory: resource.MustParse("1Gi"), | ||
| }, | ||
| }, | ||
| defaultResources: DefaultResources, | ||
| }, | ||
| }, | ||
| { | ||
| name: "Only limits are set - requests should be set from limits", | ||
| args: args{ | ||
| req: &core.ResourceRequirements{ | ||
| Limits: core.ResourceList{ | ||
| core.ResourceCPU: resource.MustParse("1"), | ||
| core.ResourceMemory: resource.MustParse("2Gi"), | ||
| }, | ||
| }, | ||
| defaultResources: DefaultResources, | ||
| }, | ||
| }, | ||
| { | ||
| name: "Nothing is set - should use default values", | ||
| args: args{ | ||
| req: &core.ResourceRequirements{}, | ||
| defaultResources: DefaultResources, | ||
| }, | ||
| }, | ||
| { | ||
| name: "Request is greater than limit", | ||
| args: args{ | ||
| req: &core.ResourceRequirements{ | ||
| Requests: core.ResourceList{ | ||
| core.ResourceCPU: resource.MustParse("300m"), | ||
| core.ResourceMemory: resource.MustParse("300Mi"), | ||
| }, | ||
| Limits: core.ResourceList{ | ||
| core.ResourceCPU: resource.MustParse("200m"), | ||
| core.ResourceMemory: resource.MustParse("200Mi"), | ||
| }, | ||
| }, | ||
| defaultResources: DefaultResources, | ||
| }, | ||
| }, | ||
| } | ||
| for _, tt := range tests { | ||
| t.Run(tt.name, func(t *testing.T) { | ||
| old := tt.args.req | ||
| SetDefaultResourceLimits(tt.args.req, tt.args.defaultResources) | ||
| if !checkExpected(tt.args.req, old) { | ||
| t.Errorf("Expected SetDefaultResourceLimits to set default limits correctly") | ||
| } | ||
| }) | ||
| } | ||
| } | ||
|
|
||
| func checkExpected(req *core.ResourceRequirements, old *core.ResourceRequirements) bool { | ||
| // Check if requests and limits are properly initialized | ||
| if req.Requests == nil || req.Limits == nil { | ||
| return false | ||
| } | ||
|
|
||
| // If both requests and limits exist, verify values are preserved or adjusted as needed | ||
| if old != nil && old.Requests != nil && old.Limits != nil { | ||
| for name, oldReq := range old.Requests { | ||
| oldLim, limExists := old.Limits[name] | ||
| if limExists { | ||
| // verify requests is preserved | ||
| if newReq, exists := req.Requests[name]; !exists || newReq.Cmp(oldReq) != 0 { | ||
| return false | ||
| } | ||
| if oldReq.Cmp(oldLim) > 0 { | ||
| // Request is greater than limit, so limit should be set to request | ||
| if newLim, exists := req.Limits[name]; !exists || newLim.Cmp(oldReq) != 0 { | ||
| return false | ||
| } | ||
| } else { | ||
| // verify limit is preserved | ||
| if newLim, exists := req.Limits[name]; !exists || newLim.Cmp(oldLim) != 0 { | ||
| return false | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
|
||
| // If old requests existed but no limits, verify limits are set from requests | ||
| if old != nil && old.Requests != nil && len(old.Limits) == 0 { | ||
| for name, oldReq := range old.Requests { | ||
| if newLim, exists := req.Limits[name]; !exists || newLim.Cmp(oldReq) != 0 { | ||
| return false | ||
| } | ||
| // Also verify that request value is preserved | ||
| if newReq, exists := req.Requests[name]; !exists || newReq.Cmp(oldReq) != 0 { | ||
| return false | ||
| } | ||
| } | ||
| } | ||
|
|
||
| // If old limits existed but no requests, verify requests are set from limits | ||
| if old != nil && old.Limits != nil && len(old.Requests) == 0 { | ||
| for name, oldLim := range old.Limits { | ||
| if newReq, exists := req.Requests[name]; !exists || newReq.Cmp(oldLim) != 0 { | ||
| return false | ||
| } | ||
| // Also verify that limit value is preserved | ||
| if newLim, exists := req.Limits[name]; !exists || newLim.Cmp(oldLim) != 0 { | ||
| return false | ||
| } | ||
| } | ||
| } | ||
|
|
||
| // If neither requests nor limits existed, verify default values are used | ||
| if old != nil && len(old.Requests) == 0 && len(old.Limits) == 0 { | ||
| // CPU check | ||
| if cpuReq, exists := req.Requests[core.ResourceCPU]; !exists || cpuReq.Cmp(*DefaultResources.Requests.Cpu()) != 0 { | ||
| return false | ||
| } | ||
| if cpuLim, exists := req.Limits[core.ResourceCPU]; !exists || cpuLim.Cmp(*DefaultResources.Limits.Cpu()) != 0 { | ||
| return false | ||
| } | ||
| // Memory check | ||
| if memReq, exists := req.Requests[core.ResourceMemory]; !exists || memReq.Cmp(*DefaultResources.Requests.Memory()) != 0 { | ||
| return false | ||
| } | ||
| if memLim, exists := req.Limits[core.ResourceMemory]; !exists || memLim.Cmp(*DefaultResources.Limits.Memory()) != 0 { | ||
| return false | ||
| } | ||
| } | ||
|
|
||
| // For all cases, ensure limits are not less than requests | ||
| for name, reqVal := range req.Requests { | ||
| if limVal, exists := req.Limits[name]; !exists || limVal.Cmp(reqVal) < 0 { | ||
| return false | ||
| } | ||
| } | ||
|
|
||
| return true | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.