Add scaleUp & scaleDown diffPercentage fields to autoscaler (#1092)

Signed-off-by: Arnob kumar saha <arnob@appscode.com>
kubedb · Dec 26, 2023 · 750f638 · 750f638
1 parent 0922ff1
commit 750f638
Show file tree

Hide file tree

Showing 30 changed files with 248 additions and 110 deletions.
diff --git a/apis/autoscaling/v1alpha1/elasticsearch_types.go b/apis/autoscaling/v1alpha1/elasticsearch_types.go
@@ -71,7 +71,7 @@ type ElasticsearchAutoscalerSpec struct {
 
 type ElasticsearchComputeAutoscalerSpec struct {
 	// +optional
-	NodeTopologyRef *core.LocalObjectReference `json:"nodeTopologyRef,omitempty"`
+	NodeTopology *NodeTopology `json:"nodeTopology,omitempty"`
 
 	Node         *ComputeAutoscalerSpec `json:"node,omitempty"`
 	Master       *ComputeAutoscalerSpec `json:"master,omitempty"`

diff --git a/apis/autoscaling/v1alpha1/mariadb_types.go b/apis/autoscaling/v1alpha1/mariadb_types.go
@@ -69,7 +69,7 @@ type MariaDBAutoscalerSpec struct {
 
 type MariaDBComputeAutoscalerSpec struct {
 	// +optional
-	NodeTopologyRef *core.LocalObjectReference `json:"nodeTopologyRef,omitempty"`
+	NodeTopology *NodeTopology `json:"nodeTopology,omitempty"`
 
 	MariaDB *ComputeAutoscalerSpec `json:"mariadb,omitempty"`
 }

diff --git a/apis/autoscaling/v1alpha1/mongodb_types.go b/apis/autoscaling/v1alpha1/mongodb_types.go
@@ -69,7 +69,7 @@ type MongoDBAutoscalerSpec struct {
 
 type MongoDBComputeAutoscalerSpec struct {
 	// +optional
-	NodeTopologyRef *core.LocalObjectReference `json:"nodeTopologyRef,omitempty"`
+	NodeTopology *NodeTopology `json:"nodeTopology,omitempty"`
 
 	Standalone   *ComputeAutoscalerSpec `json:"standalone,omitempty"`
 	ReplicaSet   *ComputeAutoscalerSpec `json:"replicaSet,omitempty"`

diff --git a/apis/autoscaling/v1alpha1/mysql_types.go b/apis/autoscaling/v1alpha1/mysql_types.go
@@ -71,7 +71,7 @@ type MySQLAutoscalerSpec struct {
 
 type MySQLComputeAutoscalerSpec struct {
 	// +optional
-	NodeTopologyRef *core.LocalObjectReference `json:"nodeTopologyRef,omitempty"`
+	NodeTopology *NodeTopology `json:"nodeTopology,omitempty"`
 
 	MySQL *ComputeAutoscalerSpec `json:"mysql,omitempty"`
 }

diff --git a/apis/autoscaling/v1alpha1/openapi_generated.go b/apis/autoscaling/v1alpha1/openapi_generated.go
diff --git a/apis/autoscaling/v1alpha1/perconaxtradb_types.go b/apis/autoscaling/v1alpha1/perconaxtradb_types.go
@@ -69,7 +69,7 @@ type PerconaXtraDBAutoscalerSpec struct {
 
 type PerconaXtraDBComputeAutoscalerSpec struct {
 	// +optional
-	NodeTopologyRef *core.LocalObjectReference `json:"nodeTopologyRef,omitempty"`
+	NodeTopology *NodeTopology `json:"nodeTopology,omitempty"`
 
 	PerconaXtraDB *ComputeAutoscalerSpec `json:"perconaxtradb,omitempty"`
 }

diff --git a/apis/autoscaling/v1alpha1/postgres_types.go b/apis/autoscaling/v1alpha1/postgres_types.go
@@ -71,7 +71,7 @@ type PostgresAutoscalerSpec struct {
 
 type PostgresComputeAutoscalerSpec struct {
 	// +optional
-	NodeTopologyRef *core.LocalObjectReference `json:"nodeTopologyRef,omitempty"`
+	NodeTopology *NodeTopology `json:"nodeTopology,omitempty"`
 
 	Postgres *ComputeAutoscalerSpec `json:"postgres,omitempty"`
 }

diff --git a/apis/autoscaling/v1alpha1/proxysql_types.go b/apis/autoscaling/v1alpha1/proxysql_types.go
@@ -70,7 +70,7 @@ type ProxySQLAutoscalerSpec struct {
 
 type ProxySQLComputeAutoscalerSpec struct {
 	// +optional
-	NodeTopologyRef *core.LocalObjectReference `json:"nodeTopologyRef,omitempty"`
+	NodeTopology *NodeTopology `json:"nodeTopology,omitempty"`
 
 	ProxySQL *ComputeAutoscalerSpec `json:"proxysql,omitempty"`
 }

diff --git a/apis/autoscaling/v1alpha1/redis_sentinel_types.go b/apis/autoscaling/v1alpha1/redis_sentinel_types.go
@@ -70,7 +70,7 @@ type RedisSentinelAutoscalerSpec struct {
 
 type RedisSentinelComputeAutoscalerSpec struct {
 	// +optional
-	NodeTopologyRef *core.LocalObjectReference `json:"nodeTopologyRef,omitempty"`
+	NodeTopology *NodeTopology `json:"nodeTopology,omitempty"`
 
 	Sentinel *ComputeAutoscalerSpec `json:"sentinel,omitempty"`
 }

diff --git a/apis/autoscaling/v1alpha1/redis_types.go b/apis/autoscaling/v1alpha1/redis_types.go
@@ -71,7 +71,7 @@ type RedisAutoscalerSpec struct {
 
 type RedisComputeAutoscalerSpec struct {
 	// +optional
-	NodeTopologyRef *core.LocalObjectReference `json:"nodeTopologyRef,omitempty"`
+	NodeTopology *NodeTopology `json:"nodeTopology,omitempty"`
 
 	Standalone *ComputeAutoscalerSpec `json:"standalone,omitempty"`
 	Cluster    *ComputeAutoscalerSpec `json:"cluster,omitempty"`

diff --git a/apis/autoscaling/v1alpha1/type.go b/apis/autoscaling/v1alpha1/type.go
@@ -24,6 +24,21 @@ import (
 	kmapi "kmodules.xyz/client-go/api/v1"
 )
 
+type NodeTopology struct {
+	// Name of the NodeTopology object
+	Name string `json:"name,omitempty"`
+	// ScaleUpDiffPercentage describes in which difference (between recommended resource and the capacity of the nodePool) the opsReq should be triggered while scaling up
+	// Defaults to 15
+	// +optional
+	// +kubebuilder:default=15
+	ScaleUpDiffPercentage *int32 `json:"scaleUpDiffPercentage"`
+	// ScaleDownDiffPercentage describes in which difference (between recommended resource and the capacity of the nodePool) the opsReq should be triggered while scaling down
+	// Defaults to 25
+	// +optional
+	// +kubebuilder:default=25
+	ScaleDownDiffPercentage *int32 `json:"scaleDownDiffPercentage"`
+}
+
 // ContainerControlledValues controls which resource value should be autoscaled.
 // +kubebuilder:validation:Enum=RequestsAndLimits;RequestsOnly
 type ContainerControlledValues string