Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deps: Remove unused ktor-client-cio dependency #624

Merged
merged 1 commit into from
Feb 22, 2025

Conversation

ksharma-xyz
Copy link
Owner

@ksharma-xyz ksharma-xyz commented Feb 21, 2025

TL;DR

Removed unused Ktor CIO client dependency from the project

What changed?

  • Removed ktor-client-cio dependency from build.gradle.kts
  • Removed corresponding entry from libs.versions.toml

How to test?

  1. Build the project and verify it compiles successfully
  2. Run the application and confirm network operations still function as expected
  3. Verify no CIO-related compilation errors or warnings appear

Why make this change?

The CIO client was not being utilized in the project as we're using platform-specific HTTP clients (OkHttp for Android and Darwin for iOS). Removing this unused dependency helps reduce the application's dependency footprint and prevents potential conflicts.

Copy link
Owner Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ksharma-xyz ksharma-xyz changed the title REmove ktor cio Deps: Remove unused ktor-client-cio dependency Feb 21, 2025
@ksharma-xyz ksharma-xyz marked this pull request as ready for review February 21, 2025 04:47
@ksharma-xyz ksharma-xyz merged commit 338d101 into main Feb 22, 2025
4 checks passed
@ksharma-xyz ksharma-xyz deleted the 02-18-remove_ktor_cio branch February 22, 2025 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant