Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Add transport mode filtering to trip planner #609

Merged
merged 2 commits into from
Feb 12, 2025

Conversation

ksharma-xyz
Copy link
Owner

@ksharma-xyz ksharma-xyz commented Feb 12, 2025

TL;DR

Added transport mode filtering functionality to the trip planner

What changed?

  • Added support for excluding specific transport modes (train, bus, ferry, etc.) when planning trips
  • Implemented mode selection UI with toggle functionality
  • Added parameter handling for excluded transport modes in the API service
  • Updated the TimeTableViewModel to handle mode selection changes and trigger API requests

How to test?

  1. Navigate to the trip planner screen
  2. Plan a journey between two locations
  3. Use the transport mode filters to exclude specific modes (e.g., trains or buses)
  4. Verify that the journey results update to exclude the selected transport modes
  5. Toggle different combinations of transport modes and confirm the results update accordingly

Why make this change?

To provide users with more control over their journey planning by allowing them to exclude transport modes they don't want to use. This is particularly useful for users who have preferences for specific types of transport or want to avoid certain modes of travel.

@ksharma-xyz ksharma-xyz changed the title Implement onModeSelectionChanged UI: Add transport mode filtering to trip planner Feb 12, 2025
@ksharma-xyz ksharma-xyz marked this pull request as ready for review February 12, 2025 11:57
@ksharma-xyz ksharma-xyz force-pushed the 02-12-add_modeselectionchanged_event branch from 31d3561 to d812367 Compare February 12, 2025 13:31
@ksharma-xyz ksharma-xyz force-pushed the 02-12-implement_onmodeselectionchanged branch from a71fce2 to 3ca37fe Compare February 12, 2025 13:52
@ksharma-xyz ksharma-xyz force-pushed the 02-12-add_modeselectionchanged_event branch from d812367 to ea7c5c7 Compare February 12, 2025 13:52
Base automatically changed from 02-12-add_modeselectionchanged_event to main February 12, 2025 14:13
Copy link
Owner Author

ksharma-xyz commented Feb 12, 2025

Merge activity

  • Feb 12, 9:13 AM EST: Graphite rebased this pull request after merging its parent, because this pull request is set to merge when ready.
  • Feb 12, 5:53 PM EST: A user merged this pull request with Graphite.

@ksharma-xyz ksharma-xyz merged commit 17e7801 into main Feb 12, 2025
2 checks passed
@ksharma-xyz ksharma-xyz deleted the 02-12-implement_onmodeselectionchanged branch February 12, 2025 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant