Analytics: Rename transportMode to themeId in theme selection event #593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksharma-xyz
changed the title
ksharma-xyz
had a problem deploying
to
Firebase
GitHub Actions
Failure
ksharma-xyz
force-pushed
the
02-07-rename_themeseletion_analytics_param_name
branch
from
ed0d1e3 to
14e3766
Compare
ksharma-xyz
deleted the
02-07-rename_themeseletion_analytics_param_name
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Updated theme selection analytics to track theme IDs instead of transport modes
What changed?
transportModeparameter tothemeIdinThemeSelectedEventHow to test?
Why make this change?
Tracking raw theme IDs provides more accurate analytics data compared to converting them to transport modes, which may not always have a direct mapping. This change simplifies the analytics implementation and makes it more maintainable.