UI: Refactor DateTime selection to use serialized model #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pi calls or other decision making process
This stack of pull requests is managed by Graphite. Learn more about stacking. |
ksharma-xyz
changed the title
Merge activity
|
ksharma-xyz
deleted the
11-30-navigation_pass_datetimeselectionitem_object_so_it_can_be_used_for_api_calls_or_other_decision_making_process
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Updated the date/time selector to pass structured data instead of formatted strings between screens.
What changed?
DateTimeSelectorScreento passDateTimeSelectionItemobjects instead of formatted stringsDateTimeSelectionItemTimeTableScreenandTimeTableDestinationto handle the new structured data formatHow to test?
Why make this change?
Using structured data instead of formatted strings provides better type safety and flexibility in handling date/time selections. This change also makes it easier to modify the date/time display format without changing the underlying data structure.