Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Enhance DateTime selector with animations and component separation #397

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

ksharma-xyz
Copy link
Owner

@ksharma-xyz ksharma-xyz commented Nov 29, 2024

TL;DR

Enhanced the date/time selector UI with improved animations and component organization

What changed?

  • Increased IconButton size from 48dp to 56dp for better touch targets
  • Added smooth animations to RadioButton selection state
  • Split DateTimeSelectorScreen into smaller, focused components
  • Introduced JourneyTimeOptions enum for Leave/Arrive selection
  • Added click handling and state management for journey time selection
  • Created separate files for DateSelection, TimeSelection, and JourneyTimeOptionsGroup

How to test?

  1. Navigate to the date/time selector screen
  2. Verify the radio button animations when switching between "Leave" and "Arrive"
  3. Confirm the larger touch targets for navigation arrows
  4. Test that time selection works correctly with the new component structure
  5. Verify that state is preserved when switching between options

Why make this change?

To improve user experience through better touch targets and visual feedback, while making the codebase more maintainable through proper component separation and state management. The animations provide better visual feedback for user interactions, and the restructured code makes it easier to maintain and modify individual components.

Copy link
Owner Author

ksharma-xyz commented Nov 29, 2024

@ksharma-xyz ksharma-xyz changed the title Create JourneyTimeOptionsGroup UI: Enhance DateTime selector with animations and component separation Nov 29, 2024
@ksharma-xyz ksharma-xyz marked this pull request as ready for review November 29, 2024 13:56
@ksharma-xyz ksharma-xyz merged commit e3314e7 into main Nov 29, 2024
2 checks passed
Copy link
Owner Author

Merge activity

  • Nov 29, 8:57 AM EST: A user merged this pull request with Graphite.

@ksharma-xyz ksharma-xyz deleted the 11-29-create_journeytimeoptionsgroup branch November 29, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant