Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Redesign DateTime selector and improve time picker layout #395

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

ksharma-xyz
Copy link
Owner

@ksharma-xyz ksharma-xyz commented Nov 29, 2024

TL;DR

Improved the date/time selector UI with enhanced styling, layout adjustments, and reduced splash screen delay for development.

What changed?

  • Reduced splash screen delay from 1200ms to 100ms for development purposes
  • Renamed backgroundColor parameter to themeColor in RadioButton component
  • Added proper theme content color handling in RadioButton
  • Enhanced DateTimeSelector screen with:
    • Reordered UI components (time picker above date selection)
    • Added selected date/time row with reset option
    • Adjusted time picker density for better visibility
    • Improved radio button layout and spacing
    • Added back navigation functionality

How to test?

  1. Navigate to the trip planner screen
  2. Click on the "Leaving Now" text
  3. Verify the date/time selector opens with:
    • Functioning radio buttons for Leave/Arrive options
    • Working time picker with proper theming
    • Visible date selection with navigation arrows
    • Back button navigation
  4. Confirm the splash screen appears briefly during development

Why make this change?

To enhance the user experience by providing a more intuitive and visually appealing date/time selection interface while improving development workflow with faster splash screen transitions.

@ksharma-xyz ksharma-xyz changed the title Update DateTimeSelector UI: Redesign DateTime selector and improve time picker layout Nov 29, 2024
Copy link
Owner Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ksharma-xyz ksharma-xyz marked this pull request as ready for review November 29, 2024 06:15
@ksharma-xyz ksharma-xyz merged commit a74643d into main Nov 29, 2024
2 checks passed
Copy link
Owner Author

Merge activity

  • Nov 29, 1:23 AM EST: A user merged this pull request with Graphite.

@ksharma-xyz ksharma-xyz deleted the 11-29-update_datetimeselector branch November 29, 2024 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant