Revert PR #472 "Always pick first syncmer as base" #479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Approved! |
marcelm
force-pushed
the
revert-basehash
branch
from
578a2d9 to
29bfe2b
Compare
|
The reverted changes are now in branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... because of a decrease of accuracy in our tests for CHM13 (mostly at telo- and centromers).
As discussed by e-mail, the problem is likely because non-canonical randstrobes, as introduced by #472, lead to biased filtering of overrepresented randstrobes: Before #472, that is, with canonical randstrobes, we would treat a randstrobe and its "reverse complement" (its version with both strobes swapped) the same. A randstrobe in the query would thus be considered overrpresented if the corresponding sequence or its reverse complement were overrepresented. With #472, this was no longer the case and whether a randstrobe is filtered or not now depends on whether it is overrpresented in the orientation that it has in the query.