Some refactoring #478
Merged
Some refactoring #478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should make it slightly more clear that this is just a regular std::vector. We also don’t havee this type of alias for any of the other vectors.
To unify how this attribute is named in various structs
This removes some code duplicated between align_or_map_single and align_or_map_paired.
|
Excellent, approved! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn’t get anywhere with the actual change I wanted to make (related to MCS), but here’s at least some refactoring I did along the way. The biggest change is factoring out a
get_nams()function that contains some code previously duplicated betweenalign_or_map_singleandalign_or_map_paired.