Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress error when accessing Linux-dependent properties. #318

Merged
merged 3 commits into from
Feb 1, 2025

Conversation

krymtkts
Copy link
Owner

resolve #317

This is a temporary fix.

@krymtkts krymtkts added the bug Something isn't working label Jan 31, 2025
@krymtkts krymtkts self-assigned this Jan 31, 2025
Copy link

codecov bot commented Jan 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.24%. Comparing base (f9c9a52) to head (3c68ebb).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #318   +/-   ##
=======================================
  Coverage   98.23%   98.24%           
=======================================
  Files           7        7           
  Lines        1076     1082    +6     
  Branches      133      133           
=======================================
+ Hits         1057     1063    +6     
  Misses         19       19           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@krymtkts krymtkts changed the title Add test to verify no errors when accessing platform-dependent properties. Suppress error when accessing Linux-dependent properties. Jan 31, 2025
Copy link
Owner Author

@krymtkts krymtkts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@krymtkts krymtkts merged commit 5c0c9a2 into main Feb 1, 2025
7 checks passed
@krymtkts krymtkts deleted the feature/fix-for-linux branch February 1, 2025 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash on Linux when using Unix-dependent properties in main branch but not in version 0.18.1
1 participant