Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump fable dependencies. #119

Merged
merged 2 commits into from
Dec 2, 2023
Merged

Bump fable dependencies. #119

merged 2 commits into from
Dec 2, 2023

Conversation

krymtkts
Copy link
Owner

@krymtkts krymtkts commented Dec 2, 2023

For #117 and #118.

@krymtkts krymtkts self-assigned this Dec 2, 2023
@krymtkts krymtkts added dependencies Pull requests that update a dependency file .NET Pull requests that update .net code labels Dec 2, 2023
Copy link
Owner Author

@krymtkts krymtkts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@krymtkts krymtkts merged commit d515151 into main Dec 2, 2023
1 check passed
@krymtkts krymtkts deleted the feature/bump-fable branch December 2, 2023 03:06
@krymtkts
Copy link
Owner Author

krymtkts commented Dec 2, 2023

to make this changes, ran following commands.

dotnet add ./src package Fable.Browser.Dom --no-restore --version 2.15.0
rm .\src\packages.lock.json

remove these from App.fsproj.

    <RestorePackagesWithLockFile>true</RestorePackagesWithLockFile>
    <RestoreLockedMode>true</RestoreLockedMode>
dotnet clean
fable clean
npm run build
# build success.

restore App.fsproj configuration.

npm run build
# lockfile regenerated successfully.

I'd like to know if there's a simpler procedure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file .NET Pull requests that update .net code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant