updating toggle icon #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changed single sort icon to two separate icons (chevron-up and chevron-down) updated toggleSortOrder to either asc or desc based on button selection added sortButtons to computed properties to calculate state of the sort buttons updated styling in order to change color of the selected sort state
Sinjhin
requested changes
Apr 15, 2024
There was a problem hiding this comment.
See comments and my example here: https://github.com/krumIO/krum-rancher-extensions/pull/36/files
We can simplify this a good bit. Visually looks good though.
- Simplified `toggleSortOrder` - A-Z or Z-A implemented based on toggle status
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses:
https://krumtest.atlassian.net/browse/APPLAUNCHER-31?atlOrigin=eyJpIjoiMDUwNDBkZmFhNTk2NDA2N2IwOGRmNzc2OGJkY2Y1YzIiLCJwIjoiaiJ9
Sorted by ASC:
Sorted by DESC: