feat: add service account impersonation support for controllers #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-hilaly
force-pushed
the
a-hilaly/impersonation
branch
from
89eec39 to
8a0d10e
Compare
Add support for per namespace service account impersonation in controllers. This enables running controller operations with different service account permissions based on namespace configuration. Key changes: - Add `ServiceAccounts` field to `ResourceGroupSpec` for mapping namespaces to service accounts - Implement dynamic client creation with service account impersonation - Add metrics for tracking impersonation `success`/`failures` and `latency` - Support default service account fallback using `"*"` key
a-hilaly
force-pushed
the
a-hilaly/impersonation
branch
from
8a0d10e to
8d151ae
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a-hilaly, michaelhtm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
a-hilaly
added a commit
that referenced
this pull request
Nov 12, 2024
Add support for per namespace service account impersonation in controllers.
This enables running controller operations with different service account
permissions based on namespace configuration.
Key changes:
- Add `ServiceAccounts` field to `ResourceGroupSpec` for mapping namespaces
to service accounts
- Implement dynamic client creation with service account impersonation
- Add metrics for tracking impersonation `success`/`failures` and `latency`
- Support default service account fallback using `"*"` key
e.g usage:
```yaml
apiVersion: x.symphony.k8s.aws/v1alpha1
kind: ResourceGroup
metadata:
name: deploymentservice.x.symphony.k8s.aws
spec:
# NOTE: this is just an initial implementation, we'll probably
# review and redesign this.
serviceAccounts:
production: prod-sa
staging: staging-sa
"*": fallback-sa
```
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
a-hilaly
added a commit
that referenced
this pull request
Nov 12, 2024
Add support for per namespace service account impersonation in controllers.
This enables running controller operations with different service account
permissions based on namespace configuration.
Key changes:
- Add `ServiceAccounts` field to `ResourceGroupSpec` for mapping namespaces
to service accounts
- Implement dynamic client creation with service account impersonation
- Add metrics for tracking impersonation `success`/`failures` and `latency`
- Support default service account fallback using `"*"` key
e.g usage:
```yaml
apiVersion: x.symphony.k8s.aws/v1alpha1
kind: ResourceGroup
metadata:
name: deploymentservice.x.symphony.k8s.aws
spec:
# NOTE: this is just an initial implementation, we'll probably
# review and redesign this.
serviceAccounts:
production: prod-sa
staging: staging-sa
"*": fallback-sa
```
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
a-hilaly
added a commit
that referenced
this pull request
Nov 12, 2024
Add support for per namespace service account impersonation in controllers.
This enables running controller operations with different service account
permissions based on namespace configuration.
Key changes:
- Add `ServiceAccounts` field to `ResourceGroupSpec` for mapping namespaces
to service accounts
- Implement dynamic client creation with service account impersonation
- Add metrics for tracking impersonation `success`/`failures` and `latency`
- Support default service account fallback using `"*"` key
e.g usage:
```yaml
apiVersion: x.symphony.k8s.aws/v1alpha1
kind: ResourceGroup
metadata:
name: deploymentservice.x.symphony.k8s.aws
spec:
# NOTE: this is just an initial implementation, we'll probably
# review and redesign this.
serviceAccounts:
production: prod-sa
staging: staging-sa
"*": fallback-sa
```
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for per namespace service account impersonation in controllers.
This enables running controller operations with different service account
permissions based on namespace configuration.
Key changes:
ServiceAccountsfield toResourceGroupSpecfor mapping namespacesto service accounts
success/failuresandlatency"*"keye.g usage:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.