feat: improve k8s resource emulator with schema constraints support #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-hilaly
force-pushed
the
a-hilaly/emulator
branch
from
224aa42 to
251c400
Compare
michaelhtm
reviewed
Oct 23, 2024
- Add handling to skip common Kubernetes top-level fields (`apiVersion`, `kind`, `metadata`) - Implement min/max constraints for number and integer field generation - Respect `minItems`/`maxItems` constraints for array generation - Refactor CR generation logic for better clarity and maintainability
a-hilaly
force-pushed
the
a-hilaly/emulator
branch
from
251c400 to
9760c80
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a-hilaly, michaelhtm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
a-hilaly
added a commit
that referenced
this pull request
Nov 12, 2024
) - Add handling to skip common Kubernetes top-level fields (`apiVersion`, `kind`, `metadata`) - Implement min/max constraints for number and integer field generation - Respect `minItems`/`maxItems` constraints for array generation - Refactor CR generation logic for better clarity and maintainability By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
a-hilaly
added a commit
that referenced
this pull request
Nov 12, 2024
) - Add handling to skip common Kubernetes top-level fields (`apiVersion`, `kind`, `metadata`) - Implement min/max constraints for number and integer field generation - Respect `minItems`/`maxItems` constraints for array generation - Refactor CR generation logic for better clarity and maintainability By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
a-hilaly
added a commit
that referenced
this pull request
Nov 12, 2024
) - Add handling to skip common Kubernetes top-level fields (`apiVersion`, `kind`, `metadata`) - Implement min/max constraints for number and integer field generation - Respect `minItems`/`maxItems` constraints for array generation - Refactor CR generation logic for better clarity and maintainability By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
apiVersion,kind,metadata)minItems/maxItemsconstraints for array generationBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.