Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(validation): add Kubernetes "version" format validation #55

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

a-hilaly
Copy link
Member

Enhance apiVersion validation in Kubernetes object structure by
adding specific checks for version format (v1, v1beta1, v1alpha1).

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-prow ack-prow bot requested review from michaelhtm and TiberiuGC October 22, 2024 05:18
@ack-prow ack-prow bot added the approved label Oct 22, 2024
Enhance `apiVersion` validation in Kubernetes object structure by
adding specific checks for version format (`v1`, `v1beta1`, `v1alpha1`).
@a-hilaly a-hilaly force-pushed the feat/validate-k8s-version branch from 870436d to 1849971 Compare October 22, 2024 05:26
Copy link
Contributor

@michaelhtm michaelhtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ack-prow ack-prow bot added the lgtm label Oct 22, 2024
Copy link

ack-prow bot commented Oct 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-hilaly, michaelhtm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [a-hilaly,michaelhtm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@michaelhtm michaelhtm merged commit f278272 into main Oct 22, 2024
3 of 4 checks passed
@a-hilaly a-hilaly deleted the feat/validate-k8s-version branch October 23, 2024 05:38
a-hilaly pushed a commit that referenced this pull request Nov 12, 2024
…sion

feat(validation): add Kubernetes "version" format validation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants