Add readiness check for resources #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelhtm
force-pushed
the
readiness-check
branch
2 times, most recently
from
e6f04d7 to
f08a3c6
Compare
a-hilaly
reviewed
Oct 16, 2024
michaelhtm
force-pushed
the
readiness-check
branch
6 times, most recently
from
5352664 to
64c732b
Compare
a-hilaly
reviewed
Oct 17, 2024
Comment on lines
+21
to
+24
| // This function parses resource condition expressions. | ||
| // These expressions need to be standalone expressions | ||
| // so, this function also does some validation. | ||
| // At the end we return the expressions with '${}' removed |
There was a problem hiding this comment.
I suggest to do a quick read on https://go.dev/blog/godoc
|
@michaelhtm also golangci-lint has a few comments on this. |
michaelhtm
force-pushed
the
readiness-check
branch
3 times, most recently
from
2150720 to
dcaa031
Compare
This feature ensures users are allowed to define when a resource is ready or not. For now this feature only allows to look within itself to see whether it's ready or not, so only its spec and status can be accessed using CEL fields. An example with deployement-service RG will be included in this PR
michaelhtm
force-pushed
the
readiness-check
branch
from
dcaa031 to
b8b4662
Compare
|
/retest |
a-hilaly
approved these changes
Oct 18, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a-hilaly, michaelhtm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ack-prow bot
pushed a commit
that referenced
this pull request
Oct 30, 2024
Issue #51 By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
a-hilaly
pushed a commit
that referenced
this pull request
Nov 12, 2024
Issue #51 By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
a-hilaly
pushed a commit
that referenced
this pull request
Nov 12, 2024
Issue #51 By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
a-hilaly
added a commit
that referenced
this pull request
Nov 12, 2024
Add readiness check for resources
a-hilaly
pushed a commit
that referenced
this pull request
Nov 12, 2024
Issue #51 By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #16
Description of changes:
This feature ensures users are allowed to define
when a resource is ready or not.
For now this feature only allows to look within itself to
see whether it's ready or not, so only its spec and status
can be accessed using CEL fields.
An example with deployement-service RG will be included i
n this PR
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.