Ignore CEL expressions for CRDs #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-hilaly
reviewed
Oct 5, 2024
internal/resourcegroup/builder.go
Outdated
| // TODO(michaelhtm): CRDs are not supported for extraction currently | ||
| // implement new logic specific to CRDs | ||
| if gvk.Kind == "CustomResourceDefinition" { | ||
| emulatedResource, err := parser.ParseSchemalessResource(unstructuredResource) |
There was a problem hiding this comment.
Suggested change
| emulatedResource, err := parser.ParseSchemalessResource(unstructuredResource) | |
| celExpressions, err := parser.ParseSchemalessResource(unstructuredResource) |
internal/resourcegroup/builder.go
Outdated
Comment on lines
134
to
136
| if emulatedResource != nil { | ||
| return nil, fmt.Errorf("failed, CEL expressions are not supported for CRDs, resource %s", rgResource.Name) | ||
| } |
There was a problem hiding this comment.
slices can be non-nil and contain 0 elements
Suggested change
| if emulatedResource != nil { | |
| return nil, fmt.Errorf("failed, CEL expressions are not supported for CRDs, resource %s", rgResource.Name) | |
| } | |
| if len(emulatedResource) > 0 { | |
| return nil, fmt.Errorf("failed, CEL expressions are not supported for CRDs, resource %s", rgResource.Name) | |
| } |
internal/resourcegroup/builder.go
Outdated
| if err != nil { | ||
| return nil, fmt.Errorf("failed to extract CEL expressions from schema for resource %s: %w", rgResource.Name, err) | ||
| } | ||
| resourceVariables = []*ResourceVariable{} |
There was a problem hiding this comment.
resourceVariable is already redeclared in L125
a-hilaly
reviewed
Oct 5, 2024
internal/resourcegroup/builder.go
Outdated
| }) | ||
| // TODO(michaelhtm): CRDs are not supported for extraction currently | ||
| // implement new logic specific to CRDs | ||
| if gvk.Kind == "CustomResourceDefinition" { |
There was a problem hiding this comment.
Should we check for the full GVK instead of just the Kind name?
michaelhtm
force-pushed
the
support-crd
branch
from
c9fbffe to
5bc154b
Compare
We are deciding to ignore CEL expressions for CRDs for now, since CRDs get some variables injected by kubernetes that don't have specific types.
michaelhtm
force-pushed
the
support-crd
branch
from
5bc154b to
a9bfad2
Compare
a-hilaly
approved these changes
Oct 7, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a-hilaly, michaelhtm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
a-hilaly
added a commit
that referenced
this pull request
Nov 12, 2024
Ignore CEL expressions for CRDs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
We are deciding to ignore CEL expressions for CRDs
for now, since CRDs get some variables injected
by kubernetes that don't have specific types.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.